-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation of Rc::make_mut
regarding rc::Weak
.
#61135
Conversation
r? @bluss (rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Co-Authored-By: Jonas Schievink <jonasschievink@gmail.com>
Ping @bluss |
Seems like a fairly straightforward improvement. I'm not a fan of "disassociated" here but can't come up with anything that sounds better so going to approve as-is. Can always iterate later. @bors r+ rollup |
📌 Commit b34b714 has been approved by |
…rk-Simulacrum Fix documentation of `Rc::make_mut` regarding `rc::Weak`. Closes rust-lang#60961
…rk-Simulacrum Fix documentation of `Rc::make_mut` regarding `rc::Weak`. Closes rust-lang#60961
Rollup of 13 pull requests Successful merges: - #61135 (Fix documentation of `Rc::make_mut` regarding `rc::Weak`.) - #61404 (miri unsizing: fix projecting into a field of an operand) - #61409 (Fix an ICE with a const argument in a trait) - #61413 (Re-implement async fn drop order lowering ) - #61419 (Add an unusual-conversion example to to_uppercase) - #61420 (Succinctify splice docs) - #61444 (Suggest using `as_ref` on `*const T`) - #61446 (On TerminatorKind::DropAndReplace still handle unused_mut correctly) - #61485 (azure: retry s3 upload if it fails) - #61489 (ci: Reenable step timings on AppVeyor) - #61496 (Do not panic in tidy on unbalanced parentheses in cfg's) - #61497 (Treat 0 as special value for codegen-units-std) - #61499 (Add regression test for existential type ICE #53457) Failed merges: r? @ghost
Closes #60961