Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate syntax of cfg attributes #53893

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Validate syntax of cfg attributes #53893

merged 2 commits into from
Sep 7, 2018

Conversation

petrochenkov
Copy link
Contributor

Fixes #53298

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2018
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Sep 2, 2018 •
edited
Loading

Needs check-only crater run.
@bors try

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2018
bors added a commit that referenced this pull request Sep 2, 2018
@bors
Auto merge of #53893 - petrochenkov:cfgexpr, r=<try>
6b43b86 
Validate syntax of `cfg` attributes

Fixes #53298
@bors
Copy link
Contributor

bors commented Sep 2, 2018

⌛ Trying commit b43e591 with merge 6b43b86...

@petrochenkov petrochenkov mentioned this pull request Sep 2, 2018
Closed
@bors
Copy link
Contributor

bors commented Sep 2, 2018

☀️ Test successful - status-travis
State: approved= try=True

@petrochenkov
Copy link
Contributor Author

ping @pietroalbini

@pietroalbini
Copy link
Member

@petrochenkov the compiler team now has direct access to craterbot, so you can queue runs yourself. Check out the bot docs and the queue dashboard.

@petrochenkov
Copy link
Contributor Author

Oh, this is nice, thanks. I'll check the docs.

@petrochenkov
Copy link
Contributor Author

@craterbot run start=master#28bcffead74d5e17c6cb1f7de432e37f93a6b50c end=try#6b43b862fabb13a0ce2a5371ea1e77ee1674b7e0 mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-53893 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-53893 is now running on agent crater-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-53893 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 5, 2018
@petrochenkov
Copy link
Contributor Author

Two regressions, both spurious.
ping @pnkfelix

@petrochenkov
Copy link
Contributor Author

Actually, the same validation needs to be performed on the command-line side.
Otherwise #[cfg(myfeature)] in code matches things like --cfg myfeature=10 on the command-line.
I'll update the PR in a couple of days.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2018
@petrochenkov
Copy link
Contributor Author

Updated with validation for --cfg command line arguments.

@petrochenkov petrochenkov added beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 5, 2018
@pnkfelix
Copy link
Member

pnkfelix commented Sep 6, 2018

Discussed in compiler team meeting. Assuming my (forthcoming) review does not lead to massive revisions, team approved this for backport to beta after it lands in master.

@pnkfelix
Copy link
Member

pnkfelix commented Sep 7, 2018

@bors r+

sorry for the delay

@bors
Copy link
Contributor

bors commented Sep 7, 2018

📌 Commit a6adeae has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2018
@pietroalbini
Copy link
Member

@bors p=1 (needs to be backported)

@pietroalbini pietroalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 7, 2018
@bors
Copy link
Contributor

bors commented Sep 7, 2018

⌛ Testing commit a6adeae with merge 24ef47b...

bors added a commit that referenced this pull request Sep 7, 2018
@bors
Auto merge of #53893 - petrochenkov:cfgexpr, r=pnkfelix
24ef47b 
Validate syntax of `cfg` attributes

Fixes #53298
@bors
Copy link
Contributor

bors commented Sep 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 24ef47b to master...

@bors bors merged commit a6adeae into rust-lang:master Sep 7, 2018
@pietroalbini pietroalbini mentioned this pull request Sep 7, 2018
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 7, 2018
bors added a commit that referenced this pull request Sep 9, 2018
@bors
Auto merge of #54037 - pietroalbini:beta-backports, r=pietroalbini
edfc72b 
[beta] Rollup backports

Merged and approved:

* #53893: Validate syntax of `cfg` attributes

r? @ghost
This was referenced Sep 12, 2018
Merged
Merged
@petrochenkov petrochenkov mentioned this pull request Sep 22, 2018
Closed
@petrochenkov petrochenkov mentioned this pull request Oct 15, 2018
Closed
@petrochenkov petrochenkov deleted the cfgexpr branch June 5, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petrochenkov @rust-highfive @bors @pietroalbini @craterbot @pnkfelix