-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIR] Change "scopes" from "visibility scopes" to "source scopes". #51182
Conversation
@bors r+ |
📌 Commit b79c898 has been approved by |
beautiful little windy path :) |
🔒 Merge conflict |
b79c898
to
06d88cd
Compare
@bors r=nikomatsakis |
📌 Commit 06d88cd has been approved by |
⌛ Testing commit 06d88cd with merge badfd1765de7d46edd6f0f7ccf0a102245fc3d33... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry
|
[MIR] Change "scopes" from "visibility scopes" to "source scopes". These scopes are already used for source-oriented diagnostics, lint levels and unsafety checks. This PR generalizes the naming around scopes, making the type `SourceScope`, and flips (across several commits) the relationship/priority between `LocalDecl`'s "visibility" and "syntactic" scopes. r? @nikomatsakis
☀️ Test successful - status-appveyor, status-travis |
These scopes are already used for source-oriented diagnostics, lint levels and unsafety checks.
This PR generalizes the naming around scopes, making the type
SourceScope
, and flips (across several commits) the relationship/priority betweenLocalDecl
's "visibility" and "syntactic" scopes.r? @nikomatsakis