configure.py --tools should set a list instead of a string #49774
Conversation
Currently the --tools option does not work because it is setting a string value for 'build.tools'. It should be a list of strings instead.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ rollup Thanks! |
|
📌 Commit 51b17db has been approved by |
bors
added
S-waiting-on-bors
configure.py --tools should set a list instead of a string Currently the --tools option does not work because it is setting a string value for 'build.tools'. It should be a list of strings instead.
|
☀️ Test successful - status-appveyor, status-travis |
Currently the --tools option does not work because it is setting a string value
for 'build.tools'. It should be a list of strings instead.