Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MSVC compilation instructions regarding path length on Windows #46252

Merged
merged 1 commit into from
Nov 26, 2017
Merged

Update MSVC compilation instructions regarding path length on Windows #46252

merged 1 commit into from
Nov 26, 2017

Conversation

zilbuz
Copy link
Contributor

@zilbuz zilbuz commented Nov 25, 2017

Fix #46214

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@zilbuz
Copy link
Contributor Author

zilbuz commented Nov 25, 2017

r? @kennytm

@kennytm kennytm added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Nov 25, 2017
@kennytm
Copy link
Member

kennytm commented Nov 25, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 25, 2017

📌 Commit 513910e has been approved by kennytm

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 25, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 25, 2017
@kennytm
Rollup merge of rust-lang#46252 - zilbuz:msvc-doc, r=kennytm
9001477 
Update MSVC compilation instructions regarding path length on Windows

Fix rust-lang#46214
@kennytm kennytm mentioned this pull request Nov 25, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Nov 26, 2017
@kennytm
Rollup merge of rust-lang#46252 - zilbuz:msvc-doc, r=kennytm
f95011b 
Update MSVC compilation instructions regarding path length on Windows

Fix rust-lang#46214
@kennytm kennytm mentioned this pull request Nov 26, 2017
Merged
bors added a commit that referenced this pull request Nov 26, 2017
@bors
Auto merge of #46272 - kennytm:rollup, r=kennytm
2c11555 
Rollup of 7 pull requests

- Successful merges: #46201, #46224, #46234, #46252, #46259, #46264, #46269
- Failed merges:
@bors bors merged commit 513910e into rust-lang:master Nov 26, 2017
@zilbuz zilbuz deleted the msvc-doc branch November 26, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zilbuz @rust-highfive @kennytm @bors @nikomatsakis