Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy: track rustc_const_unstable feature gates as well #45671

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Tidy: track rustc_const_unstable feature gates as well #45671

merged 2 commits into from
Nov 1, 2017

Conversation

est31
Copy link
Member

@est31 est31 commented Oct 31, 2017

This is important for the unstable book stub generation.

@est31
Tidy: track rustc_const_unstable feature gates as well
911e476 
This is important for the unstable book stub generation.
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@est31
Copy link
Member Author

est31 commented Oct 31, 2017

cc @steveklabnik @QuietMisdreavus

@steveklabnik
Copy link
Member

This (hopefully) addresses #44644

@QuietMisdreavus
Copy link
Member

Will this grab the AtomicInteger types? Those put their feature gates as macro input, not a full attribute: /~https://github.com/rust-lang/rust/pull/43017/files#diff-9aa1eb154ee636dcdcbcb58bc4c6f6c1R1338

@est31
Also support macro generated atomic types
6a16a7c 
This is kind of a hack but it works...
@est31
Copy link
Member Author

est31 commented Oct 31, 2017

@QuietMisdreavus good point, they should be added now.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 1, 2017

📌 Commit 6a16a7c has been approved by alexcrichton

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 1, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 1, 2017
@kennytm
Rollup merge of rust-lang#45671 - est31:master, r=alexcrichton
0284550 
Tidy: track rustc_const_unstable feature gates as well

This is important for the unstable book stub generation.
@kennytm kennytm mentioned this pull request Nov 1, 2017
Merged
bors added a commit that referenced this pull request Nov 1, 2017
@bors
Auto merge of #45674 - kennytm:rollup, r=kennytm
7402866 
Rollup of 14 pull requests

- Successful merges: #45450, #45579, #45602, #45619, #45624, #45644, #45646, #45648, #45649, #45650, #45652, #45660, #45664, #45671
- Failed merges:
@bors bors merged commit 6a16a7c into rust-lang:master Nov 1, 2017
@steveklabnik steveklabnik mentioned this pull request Jan 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@est31 @rust-highfive @steveklabnik @QuietMisdreavus @alexcrichton @bors @kennytm @aturon