Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: Downgrade to previous images temporarily #44399

Merged
merged 1 commit into from
Sep 8, 2017
Merged

travis: Downgrade to previous images temporarily #44399

merged 1 commit into from
Sep 8, 2017

Conversation

alexcrichton
Copy link
Member

Travis is in the process of rolling out an update but looks like our
tests are breaking, let's temporarily roll back to get the queue moving again.

@alexcrichton
travis: Downgrade to previous images temporarily
7ed2986 
Travis is in the process of [rolling out an update][update] but looks like our
tests are breaking, let's temporarily roll back to get the queue moving again.

[update]: https://blog.travis-ci.com/2017-08-29-trusty-image-updates
@alexcrichton
Copy link
Member Author

@bors: r+ p=100

@bors
Copy link
Contributor

bors commented Sep 7, 2017

📌 Commit 7ed2986 has been approved by alexcrichton

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Sep 7, 2017
@bors
Copy link
Contributor

bors commented Sep 7, 2017

⌛ Testing commit 7ed2986 with merge 9e939eba0d7e108fe761d0fda3e3c9e2871ddedb...

@alexcrichton alexcrichton mentioned this pull request Sep 7, 2017
Merged
@alexcrichton
Copy link
Member Author

For posterity, the last successful auto build was https://travis-ci.org/rust-lang/rust/jobs/272889516 and the next failing build was https://travis-ci.org/rust-lang/rust/jobs/273020652. We run all our builds in containers so AFAIK the only difference between these two environments is the kernel version. The kernel changed from 4.4.0-83-generic to 4.4.0-93-generic which according to this URL gives us this list of changes.

No idea what the actual cause, but investigation of the failing tests is happening on #44398

@aidanhs
Copy link
Member

aidanhs commented Sep 7, 2017

The travis cookbook also changed (travis-ci/travis-cookbooks@15a6f94...4642454) so some programs on the base image got updated too. Docker should insulate against that though, but definitely doesn't against kernel versions.

@bors
Copy link
Contributor

bors commented Sep 7, 2017

💔 Test failed - status-travis

@petrochenkov petrochenkov mentioned this pull request Sep 7, 2017
Merged
@alexcrichton
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Sep 7, 2017

⌛ Testing commit 7ed2986 with merge e1ef188...

bors added a commit that referenced this pull request Sep 7, 2017
@bors
Auto merge of #44399 - alexcrichton:tmp-travis-downgrade, r=alexcrichton
e1ef188 
travis: Downgrade to previous images temporarily

Travis is in the process of [rolling out an update][update] but looks like our
tests are breaking, let's temporarily roll back to get the queue moving again.

[update]: https://blog.travis-ci.com/2017-08-29-trusty-image-updates
@alexcrichton
Copy link
Member Author

Bug was caused by google/sanitizers#837, as discovered through these logs. According to google/sanitizers#856:

This problem is present in Linux 4.12, and fixed in 4.13rc5. Both the break and the fix are present in 4.4.84 LTS track. The breaking change is also present in Ubuntu kernel 4.4.0-93, and likely to be fixed in the following update of the kernel package.

Looks like we got unlucky with 4.4.0-93 being used.

@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 7, 2017
@bors
Copy link
Contributor

bors commented Sep 8, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing e1ef188 to master...

@bors bors merged commit 7ed2986 into rust-lang:master Sep 8, 2017
@kennytm kennytm mentioned this pull request Sep 8, 2017
Closed
@alexcrichton alexcrichton deleted the tmp-travis-downgrade branch September 8, 2017 03:44
@alexcrichton alexcrichton mentioned this pull request Sep 14, 2017
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @bors @rust-highfive @aidanhs @nikomatsakis