-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #43246
Rollup of 8 pull requests #43246
Conversation
frewsxcv
commented
Jul 15, 2017
- Successful merges: Forward more Iterator methods #43074, fail in case nothing to run was found #43145, Disable big-endian simd in swap_nonoverlapping_bytes #43159, Fix sys::redox::net::tcp #43202, windows::fs::symlink_dir: fix example to actually use symlink_dir #43222, Fix backtrace on Redox #43228, Fix minor typo in std::path documentation. #43229, Update the books. #43240
- Failed merges:
This is a workaround for rust-lang#42778, which was git-bisected to rust-lang#40454's optimizations to `mem::swap`, later moved to `ptr` in rust-lang#42819. Natively compiled rustc couldn't even compile stage1 libcore on powerpc64 and s390x, but they work fine without this `repr(simd)`. Since powerpc64le works OK, it seems probably related to being big-endian. The underlying problem is not yet known, but this at least makes those architectures functional again in the meantime. cc @arielb1
These are overridden by slice::Iter
`position` could not be implemented because calling `rposition` on the inner iterator would require more trait bounds.
Replace all `'C' as u8` with `b'C'`.
Forward more Iterator methods This allows in more cases to take advantage of specific (possibly more optimized) impls of these methods, rather than the default one defined for all `Iterator`s. I also wanted to do this for `&mut I` and `Box<I>`, but that didn’t compile for two reasons: * To make the trait object-safe, generic methods (e.g. that take a closure parameter) have a `where Self: Sized` bound. But e.g. `Box<I>: Sized` does not imply `I: Sized`, and adding an additional bound in the impl is not allowed. Some for of specialization would be needed here. * With e.g. a `F: FnMut(Self::Item) -> bool` bound and a `type Item = I::Item` associated types, I got errors like `F does not implement FnMut(I::Item) -> bool`. This looks like a limitation in the trait resolution system not recognizing that `Self::Item == I::Item` or "propagating" that fact to `FnMut` bounds.
…ng, r=Mark-Simulacrum fail in case nothing to run was found Fixes rust-lang#43121. r? @Mark-Simulacrum
Disable big-endian simd in swap_nonoverlapping_bytes This is a workaround for rust-lang#42778, which was git-bisected to rust-lang#40454's optimizations to `mem::swap`, later moved to `ptr` in rust-lang#42819. Natively compiled rustc couldn't even compile stage1 libcore on powerpc64 and s390x, but they work fine without this `repr(simd)`. Since powerpc64le works OK, it seems probably related to being big-endian. The underlying problem is not yet known, but this at least makes those architectures functional again in the meantime. cc @arielb1
Fix sys::redox::net::tcp A change to the upper level API needed to be filtered down
windows::fs::symlink_dir: fix example to actually use symlink_dir I don't have a windows machine, so I couldn't test if this doctest still works -- but it looks trivial enough. (I know, famous last words.)
Fix backtrace on Redox This fixes sys::backtrace on Redox
…ative-hahaha, r=steveklabnik Fix minor typo in std::path documentation. Fix minor typo in `std::path` documentation. Replace all `'C' as u8` with `b'C'`.
…isdreavus Update the books. `python x.py test src\doc` passes on my machine.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ p=10 |
📌 Commit e3825ec has been approved by |
⌛ Testing commit e3825ec with merge aadab827b13792f3156c8fe3b3481460acc5860c... |
💔 Test failed - status-travis |
Line 1194 of
|
@bors: retry given that travis passed, yes, I'm guessing this is spurious |
☀️ Test successful - status-appveyor, status-travis |