Add tidy check to detect empty files #41935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
est31
reviewed
May 12, 2017
src/tools/tidy/src/style.rs
Outdated
|
|
||
| if contents.is_empty() { | ||
| tidy_error!(bad, "{}: empty file", file.display()); | ||
| return |
There was a problem hiding this comment.
it should not return here, so that you get the full set of tidy errors.
There was a problem hiding this comment.
I figured the early-return would be fine since the other checks are based on contents containing things, but I guess there isn't much harm in going through them anyways.
shepmaster
added
the
S-waiting-on-author
Addresses #18439.
|
@bors r+ rollup |
|
📌 Commit 99bca6e has been approved by |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 13, 2017
…Simulacrum Add tidy check to detect empty files Addresses rust-lang#18439.
bors
added a commit
that referenced
this pull request
May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #18439.