rustc: Stabilize -C target-feature=+crt-static
#41757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit stabilizes the `crt-static` feature accepted by the compiler. Note that this does not stabilize the `#[cfg]` attribute for `crt-static` as that's going to be covered by rust-lang#29717. This only stabilizes a few small pieces: * The `crt-static` feature as accepted by the `-C target-feature` flag, and its connection with the platform-specific definition of `crt-static`. * The semantics of `--print cfg` printing out activated `crt-static` feature, if available. This should be enough to get the benefits of `crt-static` on stable Rust with MSVC and with musl, but sidsteps the issue of stabilizing rust-lang#29717 first. Closes rust-lang#37406
alexcrichton
force-pushed
the
stabilize-crt-static
branch
from
1758127 to
5013952
Compare
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @rust-lang/tools |
3 tasks
shepmaster
added
the
S-waiting-on-review
|
r? @japaric. |
|
ping @japaric for reviewing, or would you prefer to r? somone else? |
|
Sorry for the delay @alexcrichton. LGTM @bors r+ |
|
📌 Commit 5013952 has been approved by |
bors
added a commit
that referenced
this pull request
May 12, 2017
rustc: Stabilize `-C target-feature=+crt-static` This commit stabilizes the `crt-static` feature accepted by the compiler. Note that this does not stabilize the `#[cfg]` attribute for `crt-static` as that's going to be covered by #29717. This only stabilizes a few small pieces: * The `crt-static` feature as accepted by the `-C target-feature` flag, and its connection with the platform-specific definition of `crt-static`. * The semantics of `--print cfg` printing out activated `crt-static` feature, if available. This should be enough to get the benefits of `crt-static` on stable Rust with MSVC and with musl, but sidsteps the issue of stabilizing #29717 first. Closes #37406
|
☀️ Test successful - status-appveyor, status-travis |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit stabilizes the
crt-staticfeature accepted by the compiler. Notethat this does not stabilize the
#[cfg]attribute forcrt-staticasthat's going to be covered by #29717. This only stabilizes a few small pieces:
crt-staticfeature as accepted by the-C target-featureflag, and itsconnection with the platform-specific definition of
crt-static.--print cfgprinting out activatedcrt-staticfeature, ifavailable.
This should be enough to get the benefits of
crt-staticon stable Rust withMSVC and with musl, but sidsteps the issue of stabilizing #29717 first.
Closes #37406