add a per-param-env cache to impls_bound
#37152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
the
beta-nominated
|
@arielb1 r=me once you finish confirming there do not seem to be adverse performance consequences. |
There used to be only a global cache, which led to uncached calls to trait selection when there were type parameters. I'm running a check that there are no adverse performance effects. Fixes rust-lang#37106 (drop elaboration times are now ~half of borrow checking, so might still be worthy of optimization, but not critical).
|
@bors r=pnkfelix |
|
📌 Commit a61d85b has been approved by |
|
I tried this out on Serde and compile time dropped from 10 seconds using 1.14.0-nightly (a3bc191 2016-10-10) to 5.3 seconds using this commit. Thanks for taking care of this so quickly! |
bors
added a commit
that referenced
this pull request
Oct 15, 2016
add a per-param-env cache to `impls_bound` There used to be only a global cache, which led to uncached calls to trait selection when there were type parameters. This causes a 20% decrease in borrow-checking time and an overall 0.5% performance increase during bootstrapping (as borrow-checking tends to be a tiny part of compilation time). Fixes #37106 (drop elaboration times are now ~half of borrow checking, so might still be worthy of optimization, but not critical). r? @pnkfelix
alexcrichton
added
the
T-compiler
|
Seems harmless enough. I guess that this is marked for beta-backport because the elaboration code is relatively new? cc @rust-lang/compiler -- should we backport? compile-time only. |
|
SGTM as this seems to noticeably push back on a compile times regression. |
|
Marking as beta-accepted. |
nikomatsakis
added
the
beta-accepted
Merged
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There used to be only a global cache, which led to uncached calls to
trait selection when there were type parameters.
This causes a 20% decrease in borrow-checking time and an overall 0.5% performance increase during bootstrapping (as borrow-checking tends to be a tiny part of compilation time).
Fixes #37106 (drop elaboration times are now ~half of borrow checking,
so might still be worthy of optimization, but not critical).
r? @pnkfelix