Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #36472

Merged
merged 16 commits into from
Sep 14, 2016
Merged

Rollup of 5 pull requests #36472

merged 16 commits into from
Sep 14, 2016

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez
Copy link
Member Author

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Sep 14, 2016

📌 Commit 4c84d3b has been approved by GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Sep 14, 2016

⌛ Testing commit 4c84d3b with merge 22a5222...

@bors
Copy link
Contributor

bors commented Sep 14, 2016

💔 Test failed - auto-linux-64-opt

@GuillaumeGomez
Rollup merge of rust-lang#36334 - GuillaumeGomez:run_but, r=steveklabnik
d939cbe 
Set run button transparent instead of invisible

r? @steveklabnik

And of course a screenshot:

![screenshot from 2016-09-08 01-15-45](https://cloud.githubusercontent.com/assets/3050060/18331849/31fe1f8c-7562-11e6-9ae9-1dab44089ec6.png)
@GuillaumeGomez
Rollup merge of rust-lang#36363 - GuillaumeGomez:add_urls, r=stevekla…
99c2f72 
…bnik

Add urls

r? @steveklabnik
@GuillaumeGomez
Rollup merge of rust-lang#36374 - dangcheng:patch-1, r=steveklabnik
4476b7b 
book: fix mistake (File::open -> File::create)
@GuillaumeGomez
Rollup merge of rust-lang#36396 - athulappadan:Default-docs, r=bluss
a89690e 
Documentation of what Default does for each type

Addresses rust-lang#36265
I haven't changed the following types due to doubts:

1)src/libstd/ffi/c_str.rs
2)src/libcore/iter/sources.rs
3)src/libcore/hash/mod.rs
4)src/libcore/hash/mod.rs
5)src/librustc/middle/privacy.rs

r? @steveklabnik
@GuillaumeGomez
Rollup merge of rust-lang#36467 - frewsxcv:ipaddr, r=GuillaumeGomez
e368cdd 
Add doc examples for std::net::IpAddr construction.

None
@GuillaumeGomez
Copy link
Member Author

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Sep 14, 2016

📌 Commit e368cdd has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Sep 14, 2016

⌛ Testing commit e368cdd with merge 5a5736d...

bors added a commit that referenced this pull request Sep 14, 2016
@bors
Auto merge of #36472 - GuillaumeGomez:rollup, r=GuillaumeGomez
5a5736d 
Rollup of 5 pull requests

- Successful merges: #36334, #36335, #36363, #36374, #36467
- Failed merges:
@bors
Copy link
Contributor

bors commented Sep 14, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: GuillaumeGomez
Pushing 5a5736d to master...

@bors bors merged commit e368cdd into rust-lang:master Sep 14, 2016
This was referenced Sep 14, 2016
Closed
Merged
@GuillaumeGomez GuillaumeGomez deleted the rollup branch September 14, 2016 22:21
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @bors @rust-highfive @brson @Centril @danclive @athulappadan @frewsxcv