llvm, rt: build using the Ninja generator if available #34606
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
mathstuf
force-pushed
the
llvm-with-ninja
branch
2 times, most recently
from
838cea8 to
7c56d19
Compare
|
@alexcrichton Do you think we should also add this to rustbuild at the same time? |
|
@brson Rustbuild already has support for building llvm using ninja, if I remember correctly, |
|
Thanks for the PR @mathstuf! And yeah @brson I think it'd be good to implement this there as well. Right now rustbuild has support for ninja basically in the same form as this, but we probably want to hook them up. @mathstuf Could you update this match statement so rustbuild can read off the Other than that though this looks good to me! |
| @@ -68,6 +68,7 @@ pub struct Config { | |||
| pub rustc: Option<PathBuf>, | |||
| pub cargo: Option<PathBuf>, | |||
| pub local_rebuild: bool, | |||
| pub ninja: bool, | |||
There was a problem hiding this comment.
@mathstuf: There already is a ninja field defined in this struct (see line 41)
|
Thanks @mathstuf! Could you also squash the commits together? Other than that r=me |
|
@bors r=acrichto |
|
📌 Commit 33d4594 has been approved by |
|
☔ The latest upstream changes (presumably #34677) made this pull request unmergeable. Please resolve the merge conflicts. |
The Ninja generator generally builds much faster than make. It may also be used on Windows to have a vast speed improvement over the Visual Studio generators. Currently hidden behind an `--enable-ninja` flag because it does not obey the top-level `-j` or `-l` flags given to `make`.
The Visual Studio generators create a `clean` target that we can use.
|
Ping? |
|
Ah, I've been thrilled to not have to do that anymore, so I've been trying to kick that habit. |
|
⌛ Testing commit b9a3590 with merge 257f0de... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
@bors: retry
On Sat, Jul 16, 2016 at 1:14 PM, bors notifications@github.com wrote:
|
llvm, rt: build using the Ninja generator if available The Ninja generator generally builds much faster than make. It may also be used on Windows to have a vast speed improvement over the Visual Studio generators. Currently hidden behind an `--enable-ninja` flag because it does not obey the top-level `-j` or `-l` flags given to `make`.
The Ninja generator generally builds much faster than make. It may also
be used on Windows to have a vast speed improvement over the Visual
Studio generators.
Currently hidden behind an
--enable-ninjaflag because it does notobey the top-level
-jor-lflags given tomake.