Register new snapshots #30352
Register new snapshots #30352
Conversation
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
(or anyone else) |
|
This version has a performance regression DO NOT SNAPSHOT UNTIL IT IS FIXED! |
| vtable: vtable | ||
| }) | ||
| } | ||
| pub fn cstore_to_cratestore(a: Rc<CStore>) -> Rc<for<'s> CrateStore<'s>> { |
There was a problem hiding this comment.
just kill the function. it has no reason for existing.
alexcrichton
force-pushed
the
new-snashots
branch
from
a4a212c to
bbab661
Compare
|
@arielb1 oh hm, is there an issue for that? Depending on how much the snapshot is desired it may be worth making a snapshot before the regression (or just going ahead if the regression isn't that bad anyway) |
|
@alexcrichton I guess this might be about #30242 which apparently introduced a perf regression. There's no issue for that yet AFAICT. |
| @@ -197,7 +195,6 @@ impl<T: ?Sized> !marker::Send for Rc<T> {} | |||
| impl<T: ?Sized> !marker::Sync for Rc<T> {} | |||
|
|
|||
| // remove cfg after new snapshot | |||
There was a problem hiding this comment.
Comment should be removed?
There was a problem hiding this comment.
Oops, it indeed can
alexcrichton
force-pushed
the
new-snashots
branch
from
bbab661 to
0e8ac4f
Compare
|
☔ The latest upstream changes (presumably #30457) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
new-snashots
branch
from
0e8ac4f to
f17e67e
Compare
|
Rebased and updated with new snapshots that include #30368 |
alexcrichton
force-pushed
the
new-snashots
branch
from
f17e67e to
afa656a
Compare
|
@bors r+ p=1 Travis has been kind of flaky lately, eh? Is there a reason for that? |
|
📌 Commit afa656a has been approved by |
|
⌛ Testing commit afa656a with merge 9bffee0... |
|
💔 Test failed - auto-win-gnu-32-opt |
|
@bors: retry |
alexcrichton
force-pushed
the
new-snashots
branch
from
afa656a to
34a75ea
Compare
|
@bors: r=nikomatsakis 34a75ea7abc6472498e91f7e7f2d7484429b7aa9 Actually travis seems to be pretty reliable for me at least as that's a test I needed to fix! |
|
⌛ Testing commit 34a75ea with merge 14cea44... |
|
💔 Test failed - auto-mac-64-nopt-t |
Lots of cruft to remove!
alexcrichton
force-pushed
the
new-snashots
branch
from
34a75ea to
cd1848a
Compare
|
⌛ Testing commit cd1848a with merge 0c158e7... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry On Mon, Dec 21, 2015 at 11:11 AM, bors notifications@github.com wrote:
|
Lots of cruft to remove!