Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject "+" and "-" when parsing floats. #29050

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Reject "+" and "-" when parsing floats. #29050

merged 1 commit into from
Oct 15, 2015

Conversation

hanna-kruppe
Copy link
Contributor

Fixes #29042

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 71dcd7f

Thanks!

Also nominating for a backport to beta

@alexcrichton
Copy link
Member

triage: beta-nomianted

@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed beta-nomianted labels Oct 14, 2015
@alexcrichton
Copy link
Member

This libs team decided today to accept this for a backport.

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 15, 2015
bors added a commit that referenced this pull request Oct 15, 2015
@bors
Auto merge of #29050 - rkruppe:dec2flt-lonely-sign, r=alexcrichton
be3d390 
Fixes #29042
@bors
Copy link
Contributor

bors commented Oct 15, 2015

⌛ Testing commit 71dcd7f with merge be3d390...

@bors
Copy link
Contributor

bors commented Oct 15, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 71dcd7f into rust-lang:master Oct 15, 2015
@brson brson mentioned this pull request Oct 16, 2015
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 16, 2015
@hanna-kruppe hanna-kruppe mentioned this pull request Jan 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanna-kruppe @rust-highfive @alexcrichton @bors @aturon