Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop a private method on SipHasher from shadowing Hasher::write #28375

Merged
merged 1 commit into from
Sep 12, 2015
Merged

Stop a private method on SipHasher from shadowing Hasher::write #28375

merged 1 commit into from
Sep 12, 2015
+3 −8

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Sep 12, 2015

Closes #28374

@rust-highfive
Copy link
Collaborator

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@tbu-
Copy link
Contributor Author

tbu- commented Sep 12, 2015

You couldn't call sip.write before, because the inherent method shadowed the method of Hasher.

@alexcrichton
Copy link
Member

@bors: r+ d0426fd

@bors
Copy link
Contributor

bors commented Sep 12, 2015

⌛ Testing commit d0426fd with merge 50a6c79...

bors added a commit that referenced this pull request Sep 12, 2015
@bors
Auto merge of #28375 - tbu-:pr_sip_write, r=alexcrichton
50a6c79
@bors
Copy link
Contributor

bors commented Sep 12, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit d0426fd into rust-lang:master Sep 12, 2015
@sfackler
Copy link
Member

Is there an issue filed for the larger issue in method resolution that caused this?

@arielb1
Copy link
Contributor

arielb1 commented Sep 13, 2015

@sfackler

#12808 (kind-of)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@huonw huonw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tbu- @rust-highfive @alexcrichton @bors @sfackler @arielb1 @huonw