Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check upvars in closures that are in statics #28131

Merged
merged 1 commit into from
Oct 1, 2015
Merged

check upvars in closures that are in statics #28131

merged 1 commit into from
Oct 1, 2015

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Aug 31, 2015

Fixes #23057
Fixes #27890
Fixes #28099
Fixes #28113

r? @pnkfelix

arielb1
arielb1 reviewed Aug 31, 2015
View reviewed changes
src/test/compile-fail/borrowck-in-static.rs
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// check that borrowck looks inside consts/statics
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.

@alexcrichton
Copy link
Member

ping r? @pnkfelix

@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2015

📌 Commit 565da72 has been approved by pnkfelix

@bors
Copy link
Contributor

bors commented Sep 30, 2015

⌛ Testing commit 565da72 with merge 7a78969...

@bors
Copy link
Contributor

bors commented Sep 30, 2015

💔 Test failed - auto-win-msvc-64-opt

@arielb1
Copy link
Contributor Author

arielb1 commented Oct 1, 2015

@bors r=pnkfelix c01e050

@bors
Copy link
Contributor

bors commented Oct 1, 2015

⌛ Testing commit c01e050 with merge 24202c6...

bors added a commit that referenced this pull request Oct 1, 2015
@bors
Auto merge of #28131 - arielb1:static-upvars, r=pnkfelix
24202c6 
Fixes #23057 
Fixes #27890
Fixes #28099
Fixes #28113

r? @pnkfelix
@bors
Copy link
Contributor

bors commented Oct 1, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit c01e050 into rust-lang:master Oct 1, 2015
@arielb1 arielb1 mentioned this pull request Oct 5, 2015
Closed
@alexcrichton
Copy link
Member

triage: beta-nominated

@arielb1 indicates that the regression reported in #28801 was fixed by this PR (e.g. working in 1.3, broken in 1.4 (beta), and working in 1.5), so nominating for a backport to beta.

@rust-highfive rust-highfive added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 5, 2015
@alexcrichton alexcrichton added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 5, 2015
@pnkfelix
Copy link
Member

@rust-lang/compiler I'm in favor of backporting this PR to beta.

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 16, 2015
@nikomatsakis
Copy link
Contributor

Accepted as fixes a regression.

@brson brson mentioned this pull request Oct 16, 2015
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arielb1 @alexcrichton @pnkfelix @bors @nikomatsakis @rust-highfive