Remove rampant infestation of String from ExpnInfo
#28033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 98e383c has been approved by |
|
Seems to be a 7MB improvement in memory usage for expansion ^_^ (on librustc) |
|
Travis implies |
Manishearth
force-pushed
the
compilerexpn
branch
from
98e383c to
0e36dcd
Compare
|
@bors r=eddyb |
|
📌 Commit 0e36dcd has been approved by |
|
⌛ Testing commit 0e36dcd with merge 44f7c6d... |
|
💔 Test failed - auto-mac-64-opt |
Manishearth
force-pushed
the
compilerexpn
branch
from
0e36dcd to
5c05b8f
Compare
|
@bors r=eddyb |
|
📌 Commit 5c05b8f has been approved by |
Manishearth
force-pushed
the
compilerexpn
branch
from
5c05b8f to
25cbb43
Compare
|
@bors r=eddyb |
|
📌 Commit 25cbb43 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 27, 2015
We were using them for every expansion, instead of using `Name`. Also converted `CompilerExpansion` into an enum so its nicer to use and takes up less space. Will profile later, but this should be a small improvement in memory usage. r? @eddyb
bors
added a commit
that referenced
this pull request
Aug 27, 2015
This was referenced Aug 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using them for every expansion, instead of using
Name.Also converted
CompilerExpansioninto an enum so its nicer to use and takes up less space.Will profile later, but this should be a small improvement in memory usage.
r? @eddyb