Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for ptr module. #23644

Merged
merged 1 commit into from
Mar 24, 2015
Merged

Update docs for ptr module. #23644

merged 1 commit into from
Mar 24, 2015

Conversation

mbrubeck
Copy link
Contributor

PR #23104 moved is_null and offset to an inherent impl on the raw pointer type.

I'm not sure whether or how it's possible to link to docs for that impl.

r? @steveklabnik

//! methods of the [`PtrExt` trait](trait.PtrExt.html) to check for null.
//! The `PtrExt` trait is imported by the prelude, so `is_null` etc.
//! work everywhere. The `PtrExt` also defines the `offset` method,
//! the `is_null` method of the `*const T` type to check for null.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a trailing period that shouldn't be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, this line should probably start with 'and'

@mbrubeck
Copy link
Contributor Author

Pushed a new commit with copy-edits addressing previous feedback.

PR rust-lang#23104 moved `is_null` and `offset` to an inherent impl on the raw pointer
type.
@steveklabnik
Copy link
Member

@bors: r+ rollup

@steveklabnik
Copy link
Member

Thanks!

@bors
Copy link
Contributor

bors commented Mar 23, 2015

📌 Commit 3f52d71 has been approved by steveklabnik

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 24, 2015
PR rust-lang#23104 moved `is_null` and `offset` to an inherent impl on the raw pointer type.

I'm not sure whether or how it's possible to link to docs for that impl.

r? @steveklabnik
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 24, 2015
PR rust-lang#23104 moved `is_null` and `offset` to an inherent impl on the raw pointer type.

I'm not sure whether or how it's possible to link to docs for that impl.

r? @steveklabnik
@bors bors merged commit 3f52d71 into rust-lang:master Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants