Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stablize anonymous pipe #137793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stablize anonymous pipe #137793

wants to merge 1 commit into from
+40 −47

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Feb 28, 2025 •
edited
Loading

Since #135822 is staled, I create this PR to stablise anonymous pipe

Closes #127154

@rustbot

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2025

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The Miri subtree was changed

cc @rust-lang/miri

@jieyouxu
Copy link
Member

Rolling the original libs reviewer for the other stabilization attempt.
r? @joboet

@rustbot rustbot assigned joboet and unassigned ibraheemdev Feb 28, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Feb 28, 2025

Please squash the commits

@NobodyXu NobodyXu force-pushed the stablise-annoymous-pipe branch from 791a3fd to 57bdbe6 Compare February 28, 2025 14:37
@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@jieyouxu
Copy link
Member

(Some unintentional submodule changes I think)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2025
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Mar 1, 2025

The CI error is not related to any changes in this PR:

tidy error: could not find exception package `foldhash`

@NobodyXu NobodyXu changed the title Stablise anonymous pipe Stablize anonymous pipe Mar 1, 2025
@tgross35
Copy link
Contributor

tgross35 commented Mar 1, 2025

#135822 also did some refactoring, are you also planning to put that up? If you do it in a separate PR feel free to request a review from me and we can probably merge it pretty quick.

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Mar 1, 2025

If you do it in a separate PR feel free to request a review from me and we can probably merge it pretty quick.

Yes I want to put it in separate PR, I hope this PR can merge quick and hope that debian could pick it up, so that jobserver/etc can use it to reduce their burden

@NobodyXu NobodyXu force-pushed the stablise-annoymous-pipe branch from 57bdbe6 to 8acff46 Compare March 1, 2025 13:13
@NobodyXu
Stablize feature anonymous_pipe
7acb0e3 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu force-pushed the stablise-annoymous-pipe branch from 8acff46 to 7acb0e3 Compare March 1, 2025 13:35
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Mar 1, 2025

Reverted submodules changes, and tidy passed locally, so CI should be fixed now

@jieyouxu jieyouxu mentioned this pull request Mar 1, 2025
Open
6 tasks
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Mar 1, 2025

cc @joboet this pr is ready for review

@joshtriplett
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@joboet joboet

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for anonymous pipe API
9 participants
@NobodyXu @rustbot @jieyouxu @oli-obk @rust-log-analyzer @tgross35 @joshtriplett @joboet @ibraheemdev