Stabilize anonymous_pipe

[tbu-]

Closes #127154.

Based on top of #135635 to avoid conflicts.

[rustbot]

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[tbu-]

Diff for the three commits unique to this PR: /~https://github.com/rust-lang/rust/pull/135822/files/ad28cbb423b5ab203a502ecee30d630e54ea3498..58154046a31c9af0ea7cd3131e31f7bbb470bb74.

[tbu-]

CC @NobodyXu

[NobodyXu]

Thank you!

I'm so happy that this is getting stabilised 🎉

[joboet]

The changes here look good to me, though I'd like to see another change before stabilization:

Currently, things like the Stdio: From<PipeWriter> implementations live in sys:: which IMHO is really confusing and dangerous (because people will forget to add these implementations when porting std). Could you move all the public trait implementations to io::pipe (and os::_::pipe for the platform-specific implementations)?

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

[bors]

☔ The latest upstream changes (presumably #136070) made this pull request unmergeable. Please resolve the merge conflicts.

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   --> library/std/src/io/pipe.rs:78:5
    |
76  | #[derive(Debug)]
    |          ----- in this derive macro expansion
77  | pub struct PipeReader {
78  |     inner: AnonPipe,
    |     ^^^^^^^^^^^^^^^ `AnonPipe` cannot be formatted using `{:?}`
   ::: /checkout/library/core/src/fmt/mod.rs:910:5
    |
910 |     pub macro Debug($item:item) {
    |     --------------- in this expansion of `#[derive(Debug)]`
    |     --------------- in this expansion of `#[derive(Debug)]`
    |
    = help: the trait `core::fmt::Debug` is not implemented for `AnonPipe`
    = note: add `#[derive(Debug)]` to `AnonPipe` or manually `impl core::fmt::Debug for AnonPipe`
help: consider annotating `AnonPipe` with `#[derive(Debug)]`
   --> library/std/src/sys/pal/windows/pipe.rs:19:1
19  + #[derive(Debug)]
20  | pub struct AnonPipe {
    |


error[E0277]: `AnonPipe` doesn't implement `core::fmt::Debug`
   --> library/std/src/io/pipe.rs:85:5
    |
83  | #[derive(Debug)]
    |          ----- in this derive macro expansion
84  | pub struct PipeWriter {
85  |     inner: AnonPipe,
    |     ^^^^^^^^^^^^^^^ `AnonPipe` cannot be formatted using `{:?}`
   ::: /checkout/library/core/src/fmt/mod.rs:910:5
    |
910 |     pub macro Debug($item:item) {
    |     --------------- in this expansion of `#[derive(Debug)]`
    |     --------------- in this expansion of `#[derive(Debug)]`
    |
    = help: the trait `core::fmt::Debug` is not implemented for `AnonPipe`
    = note: add `#[derive(Debug)]` to `AnonPipe` or manually `impl core::fmt::Debug for AnonPipe`
help: consider annotating `AnonPipe` with `#[derive(Debug)]`
   --> library/std/src/sys/pal/windows/pipe.rs:19:1
19  + #[derive(Debug)]
20  | pub struct AnonPipe {
    |


error[E0599]: the method `as_handle` exists for reference `&AnonPipe`, but its trait bounds were not satisfied
   --> library/std/src/os/windows/io/handle.rs:552:25
552 |         self.as_inner().as_handle()
    |                         ^^^^^^^^^
    |
   ::: library/std/src/sys/pal/windows/pipe.rs:19:1
   ::: library/std/src/sys/pal/windows/pipe.rs:19:1
    |
19  | pub struct AnonPipe {
    | ------------------- doesn't satisfy `AnonPipe: os::windows::io::handle::AsHandle`
note: trait bound `AnonPipe: os::windows::io::handle::AsHandle` was not satisfied
note: trait bound `AnonPipe: os::windows::io::handle::AsHandle` was not satisfied
   --> library/std/src/os/windows/io/handle.rs:445:9
    |
445 | impl<T: AsHandle + ?Sized> AsHandle for &T {
    |         |
    |         unsatisfied trait bound introduced here
note: the trait `os::windows::io::handle::AsHandle` must be implemented
note: the trait `os::windows::io::handle::AsHandle` must be implemented
   --> library/std/src/os/windows/io/handle.rs:426:1
426 | pub trait AsHandle {
    | ^^^^^^^^^^^^^^^^^^
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::handle::AsHandle` defines an item `as_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/handle.rs:426:1
426 | pub trait AsHandle {
    | ^^^^^^^^^^^^^^^^^^


error[E0599]: the method `as_handle` exists for reference `&AnonPipe`, but its trait bounds were not satisfied
   --> library/std/src/os/windows/io/handle.rs:571:25
571 |         self.as_inner().as_handle()
    |                         ^^^^^^^^^
    |
   ::: library/std/src/sys/pal/windows/pipe.rs:19:1
   ::: library/std/src/sys/pal/windows/pipe.rs:19:1
    |
19  | pub struct AnonPipe {
    | ------------------- doesn't satisfy `AnonPipe: os::windows::io::handle::AsHandle`
note: trait bound `AnonPipe: os::windows::io::handle::AsHandle` was not satisfied
note: trait bound `AnonPipe: os::windows::io::handle::AsHandle` was not satisfied
   --> library/std/src/os/windows/io/handle.rs:445:9
    |
445 | impl<T: AsHandle + ?Sized> AsHandle for &T {
    |         |
    |         unsatisfied trait bound introduced here
note: the trait `os::windows::io::handle::AsHandle` must be implemented
note: the trait `os::windows::io::handle::AsHandle` must be implemented
   --> library/std/src/os/windows/io/handle.rs:426:1
426 | pub trait AsHandle {
    | ^^^^^^^^^^^^^^^^^^
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::handle::AsHandle` defines an item `as_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/handle.rs:426:1
426 | pub trait AsHandle {
    | ^^^^^^^^^^^^^^^^^^


error[E0599]: no method named `as_raw_handle` found for reference `&AnonPipe` in the current scope
   --> library/std/src/os/windows/io/raw.rs:104:25
104 |         self.as_inner().as_raw_handle()
    |                         ^^^^^^^^^^^^^ method not found in `&AnonPipe`
    |
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::raw::AsRawHandle` defines an item `as_raw_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/raw.rs:22:1
22  | pub trait AsRawHandle {
    | ^^^^^^^^^^^^^^^^^^^^^


error[E0599]: no method named `as_raw_handle` found for reference `&AnonPipe` in the current scope
   --> library/std/src/os/windows/io/raw.rs:111:25
111 |         self.as_inner().as_raw_handle()
    |                         ^^^^^^^^^^^^^ method not found in `&AnonPipe`
    |
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::raw::AsRawHandle` defines an item `as_raw_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/raw.rs:22:1
22  | pub trait AsRawHandle {
    | ^^^^^^^^^^^^^^^^^^^^^

error[E0599]: no method named `into_raw_handle` found for struct `AnonPipe` in the current scope
---
19  | pub struct AnonPipe {
    | ------------------- method `into_raw_handle` not found for this struct
    |
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::raw::IntoRawHandle` defines an item `into_raw_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/raw.rs:78:1
78  | pub trait IntoRawHandle {
    | ^^^^^^^^^^^^^^^^^^^^^^^
help: there is a method `into_handle` with a similar name
    |
---
    |
210 |       unsafe fn from_raw_handle(raw_handle: RawHandle) -> io::PipeWriter {
    |                                                           -------------- expected `PipeWriter` because of return type
...
213 | /             io::PipeReader::from_inner(FromInner::from_inner(FromInner::from_inner(
214 | |                 OwnedHandle::from_raw_handle(handle),
    | |_______________^ expected `PipeWriter`, found `PipeReader`

error[E0599]: no method named `into_raw_handle` found for struct `AnonPipe` in the current scope
   --> library/std/src/os/windows/io/raw.rs:222:27
---
19  | pub struct AnonPipe {
    | ------------------- method `into_raw_handle` not found for this struct
    |
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::raw::IntoRawHandle` defines an item `into_raw_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/raw.rs:78:1
78  | pub trait IntoRawHandle {
    | ^^^^^^^^^^^^^^^^^^^^^^^
help: there is a method `into_handle` with a similar name
    |

[NobodyXu]

Hi @tbu- If you are busy and don't have time to continue this, I can open separate PRs to stablise annoynous_pipe and do the refactoring