Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: linker placement attribute proposed implementation #13661

Closed
wants to merge 2 commits into from

Conversation

farcaller
Copy link
Contributor

This is the implementation of feature in rust-lang/rfcs#44, it allows to use the following code:

#[unsafe_override_address]
static t: T = 123;

that will create a t pointing to 123 address in memory.

I also have an alternative implementation that uses &'static T and requires less patching, not sure which one is better.

Vladimir Pouzanov added 2 commits April 21, 2014 17:49
#[unsafe_override_address]
static t: T = 123

would be pointing to ((*T)123). The global is not
registered in this case.
@alexcrichton
Copy link
Member

Thank you for the reference implementation! Following our RFC protocol, however, it's not quite yet time for a PR to open up on the rust repo:

Once an RFC becomes active then authors may implement it and submit the feature as a pull request to the Rust repo. An 'active' is not a rubber stamp, and in particular still does not mean the feature will ultimately be merged; it does mean that in principle all the major stakeholders have agreed to the feature and are amenable to merging it.

Closing for now, but this is cc'd on the RFC, so it should stick around.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2023
…et, r=jonas-schievink

Fix: Handle empty `checkOnSave/target` values

This fixes a regression introduced by rust-lang#13290, in which failing to set `checkOnSave/target` (or `checkOnSave/targets`) would lead to an invalid config.

[Fixes rust-lang#13660]
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants