Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvptx64: update default alignment to match LLVM 21 #136545

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Feb 4, 2025

This changed in llvm/llvm-project@91cb8f5. The commit itself is mostly about some intrinsic instructions, but as an aside it also mentions something about addrspace for tensor memory, which I believe is what this string is telling us.

@rustbot label: +llvm-main

This changed in llvm/llvm-project@91cb8f5.
The commit itself is mostly about some intrinsic instructions, but as an
aside it also mentions something about addrspace for tensor memory,
which I believe is what this string is telling us.

@rustbot label: +llvm-main
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Feb 4, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Feb 4, 2025

cc @RDambrosio016 @kjetilkjeka

@jieyouxu jieyouxu added the O-NVPTX Target: the NVPTX LLVM backend for running rust on GPUs, https://llvm.org/docs/NVPTXUsage.html label Feb 4, 2025
@nikic
Copy link
Contributor

nikic commented Feb 15, 2025

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 15, 2025

📌 Commit e9cb36b has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang#135797 (Import initial generated 1.85 relnotes)
 - rust-lang#135909 (Export kernel descriptor for amdgpu kernels)
 - rust-lang#136545 (nvptx64: update default alignment to match LLVM 21)
 - rust-lang#137092 (abi_unsupported_vector_types: say which type is the problem)
 - rust-lang#137097 (Ignore Self in bounds check for associated types with Self:Sized)

r? `@ghost`
`@rustbot` modify labels: rollup
@oli-obk oli-obk assigned nikic and unassigned oli-obk Feb 16, 2025
@bors bors merged commit d3556c6 into rust-lang:master Feb 16, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 16, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2025
Rollup merge of rust-lang#136545 - durin42:nvptx64-align, r=nikic

nvptx64: update default alignment to match LLVM 21

This changed in llvm/llvm-project@91cb8f5. The commit itself is mostly about some intrinsic instructions, but as an aside it also mentions something about addrspace for tensor memory, which I believe is what this string is telling us.

`@rustbot` label: +llvm-main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) O-NVPTX Target: the NVPTX LLVM backend for running rust on GPUs, https://llvm.org/docs/NVPTXUsage.html S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants