Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: split x86_64-msvc job using windows 2025 #135632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI: split x86_64-msvc job using windows 2025 #135632

wants to merge 1 commit into from
+17 −11

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Jan 17, 2025 •
edited
Loading

windows-2025 seems to fix the flakiness discribed in #127883 — This PR never failed a bors try.
This PR also removes the large runner by splitting it into two free runners, addressing rust-lang/infra-team#189 🥳

Too good to be true? Let's see! My suggestion is to merge this PR and observe how it behaves in the auto branch in the public dashboard over the following weeks.

Additional context

I discussed this change in Zulip as well.

If you want to see a similar PR to this one where x86_64-msvc on windows 2022 fails in CI consistently, see #135483 (comment)

r? @Kobzol

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: dist-x86_64-msvc

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 17, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
e8d81bc 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 17, 2025

⌛ Trying commit b563fc9 with merge e8d81bcb17fe0d757c6e24a533de6f6e49bc6b3a...

@bors
Copy link
Contributor

bors commented Jan 17, 2025

☀️ Try build successful - checks-actions
Build commit: e8d81bc (e8d81bcb17fe0d757c6e24a533de6f6e49bc6b3a)

@marcoieni
Copy link
Member Author

good. It worked. Trying again to see if we were just lucky.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
f5b8f99 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 17, 2025

⌛ Trying commit b563fc9 with merge f5b8f99638fd7df176fd8a47a84352b50ea671c3...

@bors
Copy link
Contributor

bors commented Jan 17, 2025

☀️ Try build successful - checks-actions
Build commit: f5b8f99 (f5b8f99638fd7df176fd8a47a84352b50ea671c3)

@marcoieni
Copy link
Member Author

Wooo. Let's test it again.

@bors try

@bors
Copy link
Contributor

bors commented Jan 17, 2025

⌛ Trying commit b563fc9 with merge 42acc46...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
42acc46 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 18, 2025

☀️ Try build successful - checks-actions
Build commit: 42acc46 (42acc46e5861e3067f97de2d155574bc1032c422)

@marcoieni
Copy link
Member Author

marcoieni commented Jan 18, 2025 •
edited
Loading

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
42503c0 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 18, 2025

⌛ Trying commit b563fc9 with merge 42503c0eff91edd3c590358e274d0f112bb4c04e...

@bors
Copy link
Contributor

bors commented Jan 18, 2025

☀️ Try build successful - checks-actions
Build commit: 42503c0 (42503c0eff91edd3c590358e274d0f112bb4c04e)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 18, 2025

⌛ Trying commit b563fc9 with merge dcf45f7...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
dcf45f7 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 18, 2025

☀️ Try build successful - checks-actions
Build commit: dcf45f7 (dcf45f7f7db20f8b518ace2afd346e1e93b44a7e)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 18, 2025

⌛ Trying commit b563fc9 with merge 6ee2817...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
6ee2817 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 18, 2025

☀️ Try build successful - checks-actions
Build commit: 6ee2817 (6ee28179cf84c7973e4bec5680bd45bddb931a5a)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 18, 2025

⌛ Trying commit b563fc9 with merge 0697d1c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
0697d1c 
…<try>

[experiment] CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 18, 2025

☀️ Try build successful - checks-actions
Build commit: 0697d1c (0697d1c9bab61856b2d1f460c9c70922f8aae37c)

@ChrisDenton
Copy link
Member

Considering, this appears to have a high success rate, this seems worth merging.

@marcoieni
Copy link
Member Author

Yes. There's another pr from me in the merge queue right now that touches this makefile.

Once that PR is merged I'll update this PR and make it ready for review 👍

@marcoieni marcoieni force-pushed the split-x86_64-msvc-2025 branch from 5f4864f to 242b0e3 Compare January 19, 2025 11:30
@marcoieni marcoieni changed the title [experiment] CI: split x86_64-msvc job using windows 2025 CI: split x86_64-msvc job using windows 2025 Jan 19, 2025
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 19, 2025

⌛ Trying commit 242b0e3 with merge 83f3740ecd05c200fc0412eb46bdb85980a13b34...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
83f3740 
…<try>

CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 19, 2025

☀️ Try build successful - checks-actions
Build commit: 83f3740 (83f3740ecd05c200fc0412eb46bdb85980a13b34)

@marcoieni marcoieni marked this pull request as ready for review January 19, 2025 14:34
@Kobzol
Copy link
Contributor

Kobzol commented Jan 19, 2025

Let's try.

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jan 19, 2025

📌 Commit 242b0e3 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
36eb2d6 
…Kobzol

CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 19, 2025

⌛ Testing commit 242b0e3 with merge 36eb2d6...

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[2025-01-19T18:42:22Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2025-01-19T18:42:22Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2025-01-19T18:42:22Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpnccZYw#token-stream-stress@0.0.0" "--profile" "check" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln"
[2025-01-19T18:42:22Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2025-01-19T18:42:22Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpnccZYw#token-stream-stress@0.0.0" "--profile" "check" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpnccZYw\\incremental-state"
[2025-01-19T18:42:22Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2025-01-19T18:42:22Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpnccZYw#token-stream-stress@0.0.0" "--profile" "check" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpnccZYw\\incremental-state"
[2025-01-19T18:42:23Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2025-01-19T18:42:23Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2025-01-19T18:42:23Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpefInpD#token-stream-stress@0.0.0" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln"
[2025-01-19T18:42:23Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
---
[2025-01-19T18:42:24Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2025-01-19T18:42:24Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2025-01-19T18:42:24Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpOObVPT#token-stream-stress@0.0.0" "--release" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln"
[2025-01-19T18:42:24Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2025-01-19T18:42:24Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpOObVPT#token-stream-stress@0.0.0" "--release" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpOObVPT\\incremental-state"
[2025-01-19T18:42:25Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2025-01-19T18:42:25Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpOObVPT#token-stream-stress@0.0.0" "--release" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpOObVPT\\incremental-state"
Executing benchmark tuple-stress (8/8)
Preparing tuple-stress
[2025-01-19T18:42:25Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=None, patch=None, backend=Llvm, phase=dependencies
[2025-01-19T18:42:25Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=None, patch=None, backend=Llvm, phase=dependencies

@bors
Copy link
Contributor

bors commented Jan 19, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 19, 2025
@marcoieni
Copy link
Member Author

From my understanding, this should be a flaky error.
I will run this job in the bors try to confirm.

@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
@bors
Auto merge of rust-lang#135632 - marcoieni:split-x86_64-msvc-2025, r=…
53ba4de 
…<try>

CI: split x86_64-msvc job using windows 2025

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: dist-x86_64-msvc
@bors
Copy link
Contributor

bors commented Jan 19, 2025

⌛ Trying commit 242b0e3 with merge 53ba4de9d1f3e6cbdaef40d34463b16820572828...

@bors
Copy link
Contributor

bors commented Jan 19, 2025

☀️ Try build successful - checks-actions
Build commit: 53ba4de (53ba4de9d1f3e6cbdaef40d34463b16820572828)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcoieni @bors @ChrisDenton @Kobzol @rust-log-analyzer @rustbot