Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect --sysroot for rustc -vV and -Cpasses=list #135330

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jan 10, 2025

This is necessary when the specified codegen backend is in a custom sysroot.

Fixes #135165

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2025
@lqd lqd assigned lqd and unassigned fee1-dead Jan 10, 2025
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comment and CI green

compiler/rustc_driver_impl/src/lib.rs Show resolved Hide resolved
@bjorn3 bjorn3 force-pushed the respect_sysroot_in_version_printing branch from d28ea4a to a10edc9 Compare January 10, 2025 11:11
This is necessary when the specified codegen backend is in a custom
sysroot.
@bjorn3 bjorn3 force-pushed the respect_sysroot_in_version_printing branch from a10edc9 to 3b6e364 Compare January 10, 2025 11:22
@lqd
Copy link
Member

lqd commented Jan 20, 2025

@bors r+

@bors
Copy link
Contributor

bors commented Jan 20, 2025

📌 Commit 056a9ce has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 20, 2025
…printing, r=lqd

Respect --sysroot for rustc -vV and -Cpasses=list

This is necessary when the specified codegen backend is in a custom sysroot.

Fixes rust-lang#135165
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133695 (Reexport likely/unlikely in std::hint)
 - rust-lang#135330 (Respect --sysroot for rustc -vV and -Cpasses=list)
 - rust-lang#135333 (Partial progress on rust-lang#132735: Replace extern "rust-intrinsic" with #[rustc_intrinsic] across the codebase)
 - rust-lang#135741 (Recognise new IPv6 documentation range from IETF RFC 9637)
 - rust-lang#135770 (Update contributing docs for submodule/subtree changes)
 - rust-lang#135775 (Subtree update of `rust-analyzer`)
 - rust-lang#135776 (Subtree sync for rustc_codegen_cranelift)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c8c5fa4 into rust-lang:master Jan 20, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 20, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2025
Rollup merge of rust-lang#135330 - bjorn3:respect_sysroot_in_version_printing, r=lqd

Respect --sysroot for rustc -vV and -Cpasses=list

This is necessary when the specified codegen backend is in a custom sysroot.

Fixes rust-lang#135165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--sysroot ignored by -vV
7 participants