Querify MonoItem collection #132566

saethlin · 2024-11-03T18:49:57Z

Factored out of #131650. These changes are required for post-mono MIR opts, because the previous implementation would load the MIR for every Instance that we traverse (as well as invoke queries on it). The cost of that would grow massively with post-mono MIR opts because we'll need to load new MIR for every Instance, instead of re-using the optimized_mir for every Instance with the same DefId.

So the approach here is to add two new queries, items_of_instance and size_estimate, which contain the specific information about an Instance's MIR that MirUsedCollector and CGU partitioning need, respectively. Caching these significantly increases the size of the query cache, but that's justified by our improved incrementality (I'm sure walking all the MIR for a huge crate scales quite poorly).

This also changes MonoItems into a type that will retain the traversal order (otherwise we perturb a bunch of diagnostics), and will also eliminate duplicate findings. Eliminating duplicates removes about a quarter of the query cache size growth.

The perf improvements in this PR are inflated because rustc-perf uses -Zincremental-verify-ich, which makes loading MIR a lot slower because MIR contains a lot of Spans and computing the stable hash of a Span is slow. And the primary goal of this PR is to load less MIR. Some squinting at collector profile_local perf-record +stage1 runs suggests the magnitude of the improvements in this PR would be decreased by between a third and a half if that flag weren't being used. Though this effect may apply to the regressions too since most are incr-full and this change also causes such builds to encode more Spans.

saethlin · 2024-11-03T18:50:08Z

@bors try @rust-timer queue

Querify mir collection Factored out of rust-lang#131650, these changes are required for post-mono MIR opts but I want to benchmark them on their own so that I can tune the implementation. r? ghost

bors · 2024-11-03T18:55:06Z

⌛ Testing commit 785a96b with merge 2c06ca1...

bors · 2024-11-03T19:07:22Z

💔 Test failed - checks-actions

saethlin · 2024-11-03T21:39:13Z

@bors try @rust-timer queue

bors · 2024-11-03T21:40:23Z

⌛ Trying commit 7155c30 with merge 292dbc9...

…try> Querify mir collection Factored out of rust-lang#131650, these changes are required for post-mono MIR opts but I want to benchmark them on their own so that I can tune the implementation. r? ghost

bors · 2024-11-03T23:33:23Z

☀️ Try build successful - checks-actions
Build commit: 292dbc9 (292dbc9fe6c4cd01f1788c79bc0170de7fe824f6)

rust-timer · 2024-11-04T02:08:07Z

Finished benchmarking commit (292dbc9): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	1.9%	[0.4%, 6.7%]	9
Regressions ❌ (secondary)	1.6%	[0.2%, 4.0%]	28
Improvements ✅ (primary)	-6.5%	[-24.7%, -0.2%]	69
Improvements ✅ (secondary)	-10.2%	[-67.2%, -0.2%]	21
All ❌✅ (primary)	-5.5%	[-24.7%, 6.7%]	78

Max RSS (memory usage)

Results (primary -7.7%, secondary -5.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.2%	[3.2%, 5.2%]	2
Regressions ❌ (secondary)	6.3%	[6.3%, 6.3%]	1
Improvements ✅ (primary)	-8.1%	[-23.2%, -1.3%]	67
Improvements ✅ (secondary)	-5.9%	[-16.3%, -2.1%]	27
All ❌✅ (primary)	-7.7%	[-23.2%, 5.2%]	69

Cycles

Results (primary -11.4%, secondary -24.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	5.7%	[5.7%, 5.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-11.7%	[-32.2%, -1.5%]	56
Improvements ✅ (secondary)	-24.6%	[-64.6%, -2.0%]	10
All ❌✅ (primary)	-11.4%	[-32.2%, 5.7%]	57

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.261s -> 782.209s (0.25%)
Artifact size: 335.33 MiB -> 335.25 MiB (-0.02%)

saethlin · 2024-11-04T04:58:01Z

@bors try @rust-timer queue

bors · 2024-11-04T04:59:10Z

⌛ Trying commit 1add34f with merge 381511a...

…try> Querify mir collection Factored out of rust-lang#131650, these changes are required for post-mono MIR opts but I want to benchmark them on their own so that I can tune the implementation. r? ghost

bors · 2024-11-04T06:55:13Z

☀️ Try build successful - checks-actions
Build commit: 381511a (381511aae66e203fd99050cf70e18ecdac59cf78)

bors · 2024-11-12T15:03:50Z

☔ The latest upstream changes (presumably #132843) made this pull request unmergeable. Please resolve the merge conflicts.

cjgillot · 2024-11-16T13:21:21Z

Thanks!
@bors r+

bors · 2024-11-16T13:21:23Z

📌 Commit f6e913b has been approved by cjgillot

It is now in the queue for this repository.

…jgillot Querify MonoItem collection Factored out of rust-lang#131650. These changes are required for post-mono MIR opts, because the previous implementation would load the MIR for every Instance that we traverse (as well as invoke queries on it). The cost of that would grow massively with post-mono MIR opts because we'll need to load new MIR for every Instance, instead of re-using the `optimized_mir` for every Instance with the same DefId. So the approach here is to add two new queries, `items_of_instance` and `size_estimate`, which contain the specific information about an Instance's MIR that MirUsedCollector and CGU partitioning need, respectively. Caching these significantly increases the size of the query cache, but that's justified by our improved incrementality (I'm sure walking all the MIR for a huge crate scales quite poorly). This also changes `MonoItems` into a type that will retain the traversal order (otherwise we perturb a bunch of diagnostics), and will also eliminate duplicate findings. Eliminating duplicates removes about a quarter of the query cache size growth. The perf improvements in this PR are inflated because rustc-perf uses `-Zincremental-verify-ich`, which makes loading MIR a lot slower because MIR contains a lot of Spans and computing the stable hash of a Span is slow. And the primary goal of this PR is to load less MIR. Some squinting at `collector profile_local perf-record +stage1` runs suggests the magnitude of the improvements in this PR would be decreased by between a third and a half if that flag weren't being used. Though this effect may apply to the regressions too since most are incr-full and this change also causes such builds to encode more Spans.

bors · 2024-11-16T13:37:24Z

⌛ Testing commit f6e913b with merge 462976c...

rust-log-analyzer · 2024-11-16T14:31:39Z

The job x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [debuginfo-cdb] tests\debuginfo\numeric-types.rs stdout ----

error: check directive(s) from `C:\a\rust\rust\tests\debuginfo\numeric-types.rs` not found in debugger output. errors:
    (numeric-types.rs:61) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<i8>]`
    (numeric-types.rs:65) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<i16>]`
    (numeric-types.rs:69) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<i32>]`
    (numeric-types.rs:73) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<i64>]`
    (numeric-types.rs:77) `w_i128           [Type: core::num::wrapping::Wrapping<i128>]`
    (numeric-types.rs:78) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<i128>]`
    (numeric-types.rs:82) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<isize>]`
    (numeric-types.rs:86) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<u8>]`
    (numeric-types.rs:90) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<u16>]`
    (numeric-types.rs:94) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<u32>]`
    (numeric-types.rs:98) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<u64>]`
    (numeric-types.rs:102) `w_u128           [Type: core::num::wrapping::Wrapping<u128>]`
    (numeric-types.rs:103) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<u128>]`
    (numeric-types.rs:107) `    [<Raw View>]     [Type: core::num::wrapping::Wrapping<usize>]`
    (numeric-types.rs:111) `    [<Raw View>]     [Type: core::sync::atomic::AtomicBool]`
    (numeric-types.rs:115) `    [<Raw View>]     [Type: core::sync::atomic::AtomicBool]`
    (numeric-types.rs:119) `    [<Raw View>]     [Type: core::sync::atomic::AtomicI8]`
    (numeric-types.rs:123) `    [<Raw View>]     [Type: core::sync::atomic::AtomicI16]`
    (numeric-types.rs:127) `    [<Raw View>]     [Type: core::sync::atomic::AtomicI32]`
    (numeric-types.rs:131) `    [<Raw View>]     [Type: core::sync::atomic::AtomicI64]`
    (numeric-types.rs:135) `    [<Raw View>]     [Type: core::sync::atomic::AtomicIsize]`
    (numeric-types.rs:139) `    [<Raw View>]     [Type: core::sync::atomic::AtomicU8]`
    (numeric-types.rs:143) `    [<Raw View>]     [Type: core::sync::atomic::AtomicU16]`
    (numeric-types.rs:147) `    [<Raw View>]     [Type: core::sync::atomic::AtomicU32]`
    (numeric-types.rs:151) `    [<Raw View>]     [Type: core::sync::atomic::AtomicU64]`
    (numeric-types.rs:155) `    [<Raw View>]     [Type: core::sync::atomic::AtomicUsize]`
the following subset of check directive(s) was found successfully:
    (numeric-types.rs:12) `nz_i8            : 11 [Type: core::num::nonzero::NonZero<i8>]`
    (numeric-types.rs:13) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<i8>]`
    (numeric-types.rs:16) `nz_i16           : 22 [Type: core::num::nonzero::NonZero<i16>]`
    (numeric-types.rs:17) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<i16>]`
    (numeric-types.rs:20) `nz_i32           : 33 [Type: core::num::nonzero::NonZero<i32>]`
    (numeric-types.rs:21) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<i32>]`
    (numeric-types.rs:24) `nz_i64           : 44 [Type: core::num::nonzero::NonZero<i64>]`
    (numeric-types.rs:25) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<i64>]`
    (numeric-types.rs:29) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<i128>]`
    (numeric-types.rs:32) `nz_isize         : 66 [Type: core::num::nonzero::NonZero<isize>]`
    (numeric-types.rs:33) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<isize>]`
    (numeric-types.rs:36) `nz_u8            : 0x4d [Type: core::num::nonzero::NonZero<u8>]`
    (numeric-types.rs:37) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<u8>]`
    (numeric-types.rs:40) `nz_u16           : 0x58 [Type: core::num::nonzero::NonZero<u16>]`
    (numeric-types.rs:41) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<u16>]`
    (numeric-types.rs:44) `nz_u32           : 0x63 [Type: core::num::nonzero::NonZero<u32>]`
    (numeric-types.rs:45) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<u32>]`
    (numeric-types.rs:48) `nz_u64           : 0x64 [Type: core::num::nonzero::NonZero<u64>]`
    (numeric-types.rs:49) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<u64>]`
    (numeric-types.rs:53) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<u128>]`
    (numeric-types.rs:56) `nz_usize         : 0x7a [Type: core::num::nonzero::NonZero<usize>]`
    (numeric-types.rs:57) `    [<Raw View>]     [Type: core::num::nonzero::NonZero<usize>]`
    (numeric-types.rs:60) `w_i8             : 10 [Type: core::num::wrapping::Wrapping<i8>]`
    (numeric-types.rs:64) `w_i16            : 20 [Type: core::num::wrapping::Wrapping<i16>]`
    (numeric-types.rs:68) `w_i32            : 30 [Type: core::num::wrapping::Wrapping<i32>]`
    (numeric-types.rs:72) `w_i64            : 40 [Type: core::num::wrapping::Wrapping<i64>]`
    (numeric-types.rs:81) `w_isize          : 60 [Type: core::num::wrapping::Wrapping<isize>]`
    (numeric-types.rs:85) `w_u8             : 0x46 [Type: core::num::wrapping::Wrapping<u8>]`
    (numeric-types.rs:89) `w_u16            : 0x50 [Type: core::num::wrapping::Wrapping<u16>]`
    (numeric-types.rs:93) `w_u32            : 0x5a [Type: core::num::wrapping::Wrapping<u32>]`
    (numeric-types.rs:97) `w_u64            : 0x64 [Type: core::num::wrapping::Wrapping<u64>]`
    (numeric-types.rs:106) `w_usize          : 0x78 [Type: core::num::wrapping::Wrapping<usize>]`
    (numeric-types.rs:110) `a_bool_t         : true [Type: core::sync::atomic::AtomicBool]`
    (numeric-types.rs:114) `a_bool_f         : false [Type: core::sync::atomic::AtomicBool]`
    (numeric-types.rs:118) `a_i8             : 2 [Type: core::sync::atomic::AtomicI8]`
    (numeric-types.rs:122) `a_i16            : 4 [Type: core::sync::atomic::AtomicI16]`
    (numeric-types.rs:126) `a_i32            : 8 [Type: core::sync::atomic::AtomicI32]`
    (numeric-types.rs:130) `a_i64            : 16 [Type: core::sync::atomic::AtomicI64]`
    (numeric-types.rs:134) `a_isize          : 32 [Type: core::sync::atomic::AtomicIsize]`
    (numeric-types.rs:138) `a_u8             : 0x40 [Type: core::sync::atomic::AtomicU8]`
    (numeric-types.rs:142) `a_u16            : 0x80 [Type: core::sync::atomic::AtomicU16]`
    (numeric-types.rs:146) `a_u32            : 0x100 [Type: core::sync::atomic::AtomicU32]`
    (numeric-types.rs:150) `a_u64            : 0x200 [Type: core::sync::atomic::AtomicU64]`
    (numeric-types.rs:154) `a_usize          : 0x400 [Type: core::sync::atomic::AtomicUsize]`
status: exit code: 0
command: PATH="C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;C:\Program Files\PowerShell\7;C:\a\_temp\msys64\mingw64\bin;C:\a\_temp\msys64\usr\local\bin;C:\a\_temp\msys64\usr\bin;C:\a\_temp\msys64\usr\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\sccache;C:\a\_temp\setup-msys2;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.1.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.432-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\a\_temp\msys64\usr\bin\site_perl;C:\a\_temp\msys64\usr\bin\vendor_perl;C:\a\_temp\msys64\usr\bin\core_perl" "C:\\Program Files (x86)\\Windows Kits\\10\\Debuggers\\x64\\cdb.exe" "-lines" "-cf" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\debuginfo\\numeric-types.cdb\\numeric-types.debugger.script" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\debuginfo\\numeric-types.cdb\\a.exe"


************* Preparing the environment for Debugger Extensions Gallery repositories **************
   ExtensionRepository : Implicit
   UseExperimentalFeatureForNugetShare : true
   AllowNugetExeUpdate : true
   NonInteractiveNuget : true
   AllowNugetMSCredentialProviderInstall : true
   AllowParallelInitializationOfLocalRepositories : true

   EnableRedirectToV8JsProvider : false
   -- Configuring repositories
      ----> Repository : LocalInstalled, Enabled: true
      ----> Repository : UserExtensions, Enabled: true


>>>>>>>>>>>>> Preparing the environment for Debugger Extensions Gallery repositories completed, duration 0.000 seconds

************* Waiting for Debugger Extensions Gallery to Initialize **************

>>>>>>>>>>>>> Waiting for Debugger Extensions Gallery to Initialize completed, duration 0.031 seconds
   ----> Repository : UserExtensions, Enabled: true, Packages count: 0
   ----> Repository : LocalInstalled, Enabled: true, Packages count: 29
Microsoft (R) Windows Debugger Version 10.0.26100.2161 AMD64
Copyright (c) Microsoft Corporation. All rights reserved.


CommandLine: C:\a\rust\rust\build\x86_64-pc-windows-msvc\test\debuginfo\numeric-types.cdb\a.exe

************* Path validation summary **************
Response                         Time (ms)     Location
Deferred                                       srv*
Symbol search path is: srv*
Executable search path is: 
+------------------------------------------------------------------------+
| This target supports Hardware-enforced Stack Protection. A HW based    |
| This target supports Hardware-enforced Stack Protection. A HW based    |
| "Shadow Stack" may be available to assist in debugging and analysis.   |
| See aka.ms/userhsp for more info.                                      |
|                                                                        |
| dps @ssp                                                               |
+------------------------------------------------------------------------+


ModLoad: 00007ff7`06700000 00007ff7`06708000   a.exe   
ModLoad: 00007fff`e2e60000 00007fff`e3061000   ntdll.dll
ModLoad: 00007fff`e1fa0000 00007fff`e205e000   C:\Windows\System32\KERNEL32.DLL
ModLoad: 00007fff`e03e0000 00007fff`e0750000   C:\Windows\System32\KERNELBASE.dll
ModLoad: 00007fff`de910000 00007fff`de9a1000   C:\Windows\SYSTEM32\apphelp.dll
ModLoad: 00007fff`e0c50000 00007fff`e0d60000   C:\Windows\System32\ucrtbase.dll
ModLoad: 00007fff`d33b0000 00007fff`d33ce000   C:\Windows\SYSTEM32\VCRUNTIME140.dll
ModLoad: 00007fff`c7f50000 00007fff`c88bc000   C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib\std-86f5533baccc1b93.dll
ModLoad: 00007fff`e2da0000 00007fff`e2e11000   C:\Windows\System32\WS2_32.dll
ModLoad: 00007fff`df9e0000 00007fff`dfa0e000   C:\Windows\SYSTEM32\USERENV.dll
ModLoad: 00007fff`e0eb0000 00007fff`e0fce000   C:\Windows\System32\RPCRT4.dll
ModLoad: 00007fff`e0a40000 00007fff`e0abf000   C:\Windows\System32\bcryptprimitives.dll
(c28.578): Break instruction exception - code 80000003 (first chance)
ntdll!LdrpDoDebuggerBreak+0x30:
00007fff`e2f34464 cc              int     3
0:000> version
Windows 10 Version 20348 MP (8 procs) Free x64
Product: Server, suite: TerminalServer DataCenter SingleUserTS
Edition build lab: 20348.1.amd64fre.fe_release.210507-1500
Build layer: DesktopEditions -> 20348.1.amd64fre.fe_release.210507-1500
Build layer: OnecoreUAP -> 20348.2849.amd64fre.fe_release_svc_prod1.241101-1732
Build layer: ShellCommon -> 20348.2849.amd64fre.fe_release_svc_prod1.241101-1732
Debug session time: Sat Nov 16 14:31:14.670 2024 (UTC + 0:00)
System Uptime: 0 days 0:55:00.006
Process Uptime: 0 days 0:00:00.060
  Kernel time: 0 days 0:00:00.000
  User time: 0 days 0:00:00.015
Live user mode: <Local>
Microsoft (R) Windows Debugger Version 10.0.26100.2161 AMD64
Copyright (c) Microsoft Corporation. All rights reserved.


command line: '"C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\cdb.exe" -lines -cf C:\a\rust\rust\build\x86_64-pc-windows-msvc\test\debuginfo\numeric-types.cdb\numeric-types.debugger.script C:\a\rust\rust\build\x86_64-pc-windows-msvc\test\debuginfo\numeric-types.cdb\a.exe'  Debugger Process 0x6F4 
dbgeng:  image 10.0.26100.2161, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\dbgeng.dll]
dbghelp: image 10.0.26100.2161, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\dbghelp.dll]
        DIA version: 33140
Extension DLL search Path:
    C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\WINXP;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\winext;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\winext\arcade;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\pri;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64;C:\Users\runneradmin\AppData\Local\Dbg\EngineExtensions;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;C:\Program Files\PowerShell\7;C:\a\_temp\msys64\mingw64\bin;C:\a\_temp\msys64\usr\local\bin;C:\a\_temp\msys64\usr\bin;C:\a\_temp\msys64\usr\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\sccache;C:\a\_temp\setup-msys2;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.1.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.432-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\a\_temp\msys64\usr\bin\site_perl;C:\a\_temp\msys64\usr\bin\vendor_perl;C:\a\_temp\msys64\usr\bin\core_perl
Extension DLL chain:
    dbghelp: image 10.0.26100.2161, API 10.0.6, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\dbghelp.dll]
    exts: image 10.0.26100.2161, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\WINXP\exts.dll]
    uext: image 10.0.26100.2161, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\winext\uext.dll]
    ntsdexts: image 10.0.26100.2161, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\WINXP\ntsdexts.dll]
0:000> .nvlist
Loaded NatVis Files:
    <None Loaded>
0:000> bp `numeric-types.rs:287`
*** WARNING: Unable to verify checksum for a.exe
0:000>  g
Breakpoint 0 hit
a!numeric_types::main+0x596:
00007ff7`067018d6 e815000000      call    a!numeric_types::zzz (00007ff7`067018f0)
0:000>  dx nz_i8
nz_i8            : 11 [Type: core::num::nonzero::NonZero<i8>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<i8>]
0:000>  dx nz_i16
nz_i16           : 22 [Type: core::num::nonzero::NonZero<i16>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<i16>]
0:000>  dx nz_i32
nz_i32           : 33 [Type: core::num::nonzero::NonZero<i32>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<i32>]
0:000>  dx nz_i64
nz_i64           : 44 [Type: core::num::nonzero::NonZero<i64>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<i64>]
0:000>  dx nz_i128
nz_i128          : 55 [Type: core::num::nonzero::NonZero<i128>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<i128>]
0:000>  dx nz_isize
nz_isize         : 66 [Type: core::num::nonzero::NonZero<isize>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<isize>]
0:000>  dx nz_u8
nz_u8            : 0x4d [Type: core::num::nonzero::NonZero<u8>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<u8>]
0:000>  dx nz_u16
nz_u16           : 0x58 [Type: core::num::nonzero::NonZero<u16>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<u16>]
0:000>  dx nz_u32
nz_u32           : 0x63 [Type: core::num::nonzero::NonZero<u32>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<u32>]
0:000>  dx nz_u64
nz_u64           : 0x64 [Type: core::num::nonzero::NonZero<u64>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<u64>]
0:000>  dx nz_u128
nz_u128          : 111 [Type: core::num::nonzero::NonZero<u128>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<u128>]
0:000>  dx nz_usize
nz_usize         : 0x7a [Type: core::num::nonzero::NonZero<usize>]
    [<Raw View>]     [Type: core::num::nonzero::NonZero<usize>]
0:000>  dx w_i8
w_i8             : 10 [Type: core::num::wrapping::Wrapping<i8>]
    [+0x000] __0              : 10 [Type: char]
0:000>  dx w_i16
w_i16            : 20 [Type: core::num::wrapping::Wrapping<i16>]
    [+0x000] __0              : 20 [Type: short]
0:000>  dx w_i32
w_i32            : 30 [Type: core::num::wrapping::Wrapping<i32>]
    [+0x000] __0              : 30 [Type: int]
0:000>  dx w_i64
w_i64            : 40 [Type: core::num::wrapping::Wrapping<i64>]
    [+0x000] __0              : 40 [Type: __int64]
0:000>  dx w_i128
w_i128           : 50 [Type: core::num::wrapping::Wrapping<i128>]
    [+0x000] __0              : 50 [Type: i128]
0:000>  dx w_isize
w_isize          : 60 [Type: core::num::wrapping::Wrapping<isize>]
    [+0x000] __0              : 60 [Type: __int64]
0:000>  dx w_u8
w_u8             : 0x46 [Type: core::num::wrapping::Wrapping<u8>]
    [+0x000] __0              : 0x46 [Type: unsigned char]
0:000>  dx w_u16
w_u16            : 0x50 [Type: core::num::wrapping::Wrapping<u16>]
    [+0x000] __0              : 0x50 [Type: unsigned short]
0:000>  dx w_u32
w_u32            : 0x5a [Type: core::num::wrapping::Wrapping<u32>]
    [+0x000] __0              : 0x5a [Type: unsigned int]
0:000>  dx w_u64
w_u64            : 0x64 [Type: core::num::wrapping::Wrapping<u64>]
    [+0x000] __0              : 0x64 [Type: unsigned __int64]
0:000>  dx w_u128
w_u128           : 110 [Type: core::num::wrapping::Wrapping<u128>]
    [+0x000] __0              : 110 [Type: u128]
0:000>  dx w_usize
w_usize          : 0x78 [Type: core::num::wrapping::Wrapping<usize>]
    [+0x000] __0              : 0x78 [Type: unsigned __int64]
0:000>  dx a_bool_t
a_bool_t         : true [Type: core::sync::atomic::AtomicBool]
    [+0x000] v                : 0x1 [Type: core::cell::UnsafeCell<u8>]
0:000>  dx a_bool_f
a_bool_f         : false [Type: core::sync::atomic::AtomicBool]
    [+0x000] v                : 0x0 [Type: core::cell::UnsafeCell<u8>]
0:000>  dx a_i8
a_i8             : 2 [Type: core::sync::atomic::AtomicI8]
    [+0x000] v                : 2 [Type: core::cell::UnsafeCell<i8>]
0:000>  dx a_i16
a_i16            : 4 [Type: core::sync::atomic::AtomicI16]
    [+0x000] v                : 4 [Type: core::cell::UnsafeCell<i16>]
0:000>  dx a_i32
a_i32            : 8 [Type: core::sync::atomic::AtomicI32]
    [+0x000] v                : 8 [Type: core::cell::UnsafeCell<i32>]
0:000>  dx a_i64
a_i64            : 16 [Type: core::sync::atomic::AtomicI64]
    [+0x000] v                : 16 [Type: core::cell::UnsafeCell<i64>]
0:000>  dx a_isize
a_isize          : 32 [Type: core::sync::atomic::AtomicIsize]
    [+0x000] v                : 32 [Type: core::cell::UnsafeCell<isize>]
0:000>  dx a_u8
a_u8             : 0x40 [Type: core::sync::atomic::AtomicU8]
    [+0x000] v                : 0x40 [Type: core::cell::UnsafeCell<u8>]
0:000>  dx a_u16
a_u16            : 0x80 [Type: core::sync::atomic::AtomicU16]
    [+0x000] v                : 0x80 [Type: core::cell::UnsafeCell<u16>]
0:000>  dx a_u32
a_u32            : 0x100 [Type: core::sync::atomic::AtomicU32]
    [+0x000] v                : 0x100 [Type: core::cell::UnsafeCell<u32>]
0:000>  dx a_u64
a_u64            : 0x200 [Type: core::sync::atomic::AtomicU64]
    [+0x000] v                : 0x200 [Type: core::cell::UnsafeCell<u64>]
0:000>  dx a_usize
a_usize          : 0x400 [Type: core::sync::atomic::AtomicUsize]
    [+0x000] v                : 0x400 [Type: core::cell::UnsafeCell<usize>]
0:000> qq
quit:
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\atlmfc.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\ObjectiveC.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\concurrency.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\cpp_rest.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\stl.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\Windows.Data.Json.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\Windows.Devices.Geolocation.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\Windows.Devices.Sensors.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\Windows.Media.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\windows.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\winrt.natvis'
stderr: none


---- [debuginfo-cdb] tests\debuginfo\range-types.rs stdout ----
---- [debuginfo-cdb] tests\debuginfo\range-types.rs stdout ----

error: check directive(s) from `C:\a\rust\rust\tests\debuginfo\range-types.rs` not found in debugger output. errors:
    (range-types.rs:13) `    [<Raw View>]     [Type: core::ops::range::Range<i32>]`
    (range-types.rs:17) `    [<Raw View>]     [Type: core::ops::range::RangeFrom<i32>]`
    (range-types.rs:21) `    [<Raw View>]     [Type: core::ops::range::RangeInclusive<i32>]`
    (range-types.rs:25) `    [<Raw View>]     [Type: core::ops::range::RangeTo<i32>]`
    (range-types.rs:29) `    [<Raw View>]     [Type: core::ops::range::RangeToInclusive<i32>]`
the following subset of check directive(s) was found successfully:
    (range-types.rs:12) `r1,d             : (3..5) [Type: core::ops::range::Range<i32>]`
    (range-types.rs:16) `r2,d             : (2..) [Type: core::ops::range::RangeFrom<i32>]`
    (range-types.rs:20) `r3,d             : (1..=4) [Type: core::ops::range::RangeInclusive<i32>]`
    (range-types.rs:24) `r4,d             : (..10) [Type: core::ops::range::RangeTo<i32>]`
    (range-types.rs:28) `r5,d             : (..=3) [Type: core::ops::range::RangeToInclusive<i32>]`
    (range-types.rs:32) `r6,d             [Type: core::ops::range::RangeFull]`
status: exit code: 0
command: PATH="C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;C:\Program Files\PowerShell\7;C:\a\_temp\msys64\mingw64\bin;C:\a\_temp\msys64\usr\local\bin;C:\a\_temp\msys64\usr\bin;C:\a\_temp\msys64\usr\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\sccache;C:\a\_temp\setup-msys2;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.1.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.432-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\a\_temp\msys64\usr\bin\site_perl;C:\a\_temp\msys64\usr\bin\vendor_perl;C:\a\_temp\msys64\usr\bin\core_perl" "C:\\Program Files (x86)\\Windows Kits\\10\\Debuggers\\x64\\cdb.exe" "-lines" "-cf" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\debuginfo\\range-types.cdb\\range-types.debugger.script" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\debuginfo\\range-types.cdb\\a.exe"


************* Preparing the environment for Debugger Extensions Gallery repositories **************
   ExtensionRepository : Implicit
   UseExperimentalFeatureForNugetShare : true
   AllowNugetExeUpdate : true
   NonInteractiveNuget : true
   AllowNugetMSCredentialProviderInstall : true
   AllowParallelInitializationOfLocalRepositories : true

   EnableRedirectToV8JsProvider : false
   -- Configuring repositories
      ----> Repository : LocalInstalled, Enabled: true
      ----> Repository : UserExtensions, Enabled: true


>>>>>>>>>>>>> Preparing the environment for Debugger Extensions Gallery repositories completed, duration 0.000 seconds

************* Waiting for Debugger Extensions Gallery to Initialize **************

>>>>>>>>>>>>> Waiting for Debugger Extensions Gallery to Initialize completed, duration 0.031 seconds
   ----> Repository : UserExtensions, Enabled: true, Packages count: 0
   ----> Repository : LocalInstalled, Enabled: true, Packages count: 29
Microsoft (R) Windows Debugger Version 10.0.26100.2161 AMD64
Copyright (c) Microsoft Corporation. All rights reserved.


CommandLine: C:\a\rust\rust\build\x86_64-pc-windows-msvc\test\debuginfo\range-types.cdb\a.exe

************* Path validation summary **************
Response                         Time (ms)     Location
Deferred                                       srv*
Symbol search path is: srv*
Executable search path is: 
+------------------------------------------------------------------------+
| This target supports Hardware-enforced Stack Protection. A HW based    |
| This target supports Hardware-enforced Stack Protection. A HW based    |
| "Shadow Stack" may be available to assist in debugging and analysis.   |
| See aka.ms/userhsp for more info.                                      |
|                                                                        |
| dps @ssp                                                               |
+------------------------------------------------------------------------+


ModLoad: 00007ff7`cb9b0000 00007ff7`cb9b7000   a.exe   
ModLoad: 00007fff`e2e60000 00007fff`e3061000   ntdll.dll
ModLoad: 00007fff`e1fa0000 00007fff`e205e000   C:\Windows\System32\KERNEL32.DLL
ModLoad: 00007fff`e03e0000 00007fff`e0750000   C:\Windows\System32\KERNELBASE.dll
ModLoad: 00007fff`de910000 00007fff`de9a1000   C:\Windows\SYSTEM32\apphelp.dll
ModLoad: 00007fff`e0c50000 00007fff`e0d60000   C:\Windows\System32\ucrtbase.dll
ModLoad: 00007fff`d33b0000 00007fff`d33ce000   C:\Windows\SYSTEM32\VCRUNTIME140.dll
ModLoad: 00007fff`c7f50000 00007fff`c88bc000   C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib\std-86f5533baccc1b93.dll
ModLoad: 00007fff`e2da0000 00007fff`e2e11000   C:\Windows\System32\WS2_32.dll
ModLoad: 00007fff`df9e0000 00007fff`dfa0e000   C:\Windows\SYSTEM32\USERENV.dll
ModLoad: 00007fff`e0eb0000 00007fff`e0fce000   C:\Windows\System32\RPCRT4.dll
ModLoad: 00007fff`e0a40000 00007fff`e0abf000   C:\Windows\System32\bcryptprimitives.dll
(774.a68): Break instruction exception - code 80000003 (first chance)
ntdll!LdrpDoDebuggerBreak+0x30:
00007fff`e2f34464 cc              int     3
0:000> version
Windows 10 Version 20348 MP (8 procs) Free x64
Product: Server, suite: TerminalServer DataCenter SingleUserTS
Edition build lab: 20348.1.amd64fre.fe_release.210507-1500
Build layer: DesktopEditions -> 20348.1.amd64fre.fe_release.210507-1500
Build layer: OnecoreUAP -> 20348.2849.amd64fre.fe_release_svc_prod1.241101-1732
Build layer: ShellCommon -> 20348.2849.amd64fre.fe_release_svc_prod1.241101-1732
Debug session time: Sat Nov 16 14:31:15.702 2024 (UTC + 0:00)
System Uptime: 0 days 0:55:01.038
Process Uptime: 0 days 0:00:00.060
  Kernel time: 0 days 0:00:00.000
  User time: 0 days 0:00:00.000
Live user mode: <Local>
Microsoft (R) Windows Debugger Version 10.0.26100.2161 AMD64
Copyright (c) Microsoft Corporation. All rights reserved.


command line: '"C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\cdb.exe" -lines -cf C:\a\rust\rust\build\x86_64-pc-windows-msvc\test\debuginfo\range-types.cdb\range-types.debugger.script C:\a\rust\rust\build\x86_64-pc-windows-msvc\test\debuginfo\range-types.cdb\a.exe'  Debugger Process 0xB20 
dbgeng:  image 10.0.26100.2161, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\dbgeng.dll]
dbghelp: image 10.0.26100.2161, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\dbghelp.dll]
        DIA version: 33140
Extension DLL search Path:
    C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\WINXP;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\winext;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\winext\arcade;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\pri;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64;C:\Users\runneradmin\AppData\Local\Dbg\EngineExtensions;C:\Program Files (x86)\Windows Kits\10\Debuggers\x64;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;C:\Program Files\PowerShell\7;C:\a\_temp\msys64\mingw64\bin;C:\a\_temp\msys64\usr\local\bin;C:\a\_temp\msys64\usr\bin;C:\a\_temp\msys64\usr\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\sccache;C:\a\_temp\setup-msys2;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.1.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.432-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\a\_temp\msys64\usr\bin\site_perl;C:\a\_temp\msys64\usr\bin\vendor_perl;C:\a\_temp\msys64\usr\bin\core_perl
Extension DLL chain:
    dbghelp: image 10.0.26100.2161, API 10.0.6, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\dbghelp.dll]
    exts: image 10.0.26100.2161, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\WINXP\exts.dll]
    uext: image 10.0.26100.2161, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\winext\uext.dll]
    ntsdexts: image 10.0.26100.2161, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\WINXP\ntsdexts.dll]
0:000> .nvlist
Loaded NatVis Files:
    <None Loaded>
0:000> bp `range-types.rs:46`
*** WARNING: Unable to verify checksum for a.exe
0:000>  g
Breakpoint 0 hit
a!range_types::main+0x41:
00007ff7`cb9b11a1 e80a000000      call    a!range_types::zzz (00007ff7`cb9b11b0)
0:000>  dx r1,d
r1,d             : (3..5) [Type: core::ops::range::Range<i32>]
    [+0x000] start            : 3 [Type: int]
    [+0x004] end              : 5 [Type: int]
0:000>  dx r2,d
r2,d             : (2..) [Type: core::ops::range::RangeFrom<i32>]
    [+0x000] start            : 2 [Type: int]
0:000>  dx r3,d
r3,d             : (1..=4) [Type: core::ops::range::RangeInclusive<i32>]
    [+0x000] start            : 1 [Type: int]
    [+0x004] end              : 4 [Type: int]
    [+0x008] exhausted        : false [Type: bool]
0:000>  dx r4,d
r4,d             : (..10) [Type: core::ops::range::RangeTo<i32>]
    [+0x000] end              : 10 [Type: int]
0:000>  dx r5,d
r5,d             : (..=3) [Type: core::ops::range::RangeToInclusive<i32>]
    [+0x000] end              : 3 [Type: int]
0:000>  dx r6,d
r6,d             [Type: core::ops::range::RangeFull]
0:000> qq
quit:
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\atlmfc.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\ObjectiveC.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\concurrency.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\cpp_rest.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\stl.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\Windows.Data.Json.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\Windows.Devices.Geolocation.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\Windows.Devices.Sensors.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\Windows.Media.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\windows.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\Visualizers\winrt.natvis'
stderr: none


---- [debuginfo-cdb] tests\debuginfo\unit-type.rs stdout ----
---- [debuginfo-cdb] tests\debuginfo\unit-type.rs stdout ----

error: check directive(s) from `C:\a\rust\rust\tests\debuginfo\unit-type.rs` not found in debugger output. errors:
    (unit-type.rs:29) ` _ref             : 0x[...] : () [Type: tuple$<> *]`
    (unit-type.rs:32) ` _ptr             : 0x[...] : () [Type: tuple$<> *]`
    (unit-type.rs:35) ` _local           : () [Type: tuple$<>]`
    (unit-type.rs:40) `     [+0x[...]] _unit            : () [Type: tuple$<>]`
the following subset of check directive(s) was found successfully:
    (unit-type.rs:26) `Breakpoint 0 hit`
    (unit-type.rs:38) `_field,d         [Type: unit_type::_TypeContainingUnitField]`
    (unit-type.rs:39) `    [+0x008] _a               : 123 [Type: unsigned int]`
    (unit-type.rs:41) `    [+0x000] _b               : 456 [Type: unsigned __int64]`
    (unit-type.rs:45) `((__int64 *)_ptr),x : 0x183cf6fad0 : 0x1122334455667788 [Type: __int64 *]`
    (unit-type.rs:46) `    0x1122334455667788 [Type: __int64]`
status: exit code: 0
command: PATH="C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;C:\Program Files\PowerShell\7;C:\a\_temp\msys64\mingw64\bin;C:\a\_temp\msys64\usr\local\bin;C:\a\_temp\msys64\usr\bin;C:\a\_temp\msys64\usr\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\sccache;C:\a\_temp\setup-msys2;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.1.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.432-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\a\_temp\msys64\usr\bin\site_perl;C:\a\_temp\msys64\usr\bin\vendor_perl;C:\a\_temp\msys64\usr\bin\core_perl" "C:\\Program Files (x86)\\Windows Kits\\10\\Debuggers\\x64\\cdb.exe" "-lines" "-cf" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\debuginfo\\unit-type.cdb\\unit-type.debugger.script" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\debuginfo\\unit-type.cdb\\a.exe"


************* Preparing the environment for Debugger Extensions Gallery repositories **************
   ExtensionRepository : Implicit
   UseExperimentalFeatureForNugetShare : true
   AllowNugetExeUpdate : true
   NonInteractiveNuget : true
   AllowNugetMSCredentialProviderInstall : true
   AllowParallelInitializationOfLocalRepositories : true

   EnableRedirectToV8JsProvider : false
   -- Configuring repositories
      ----> Repository : LocalInstalled, Enabled: true
      ----> Repository : UserExtensions, Enabled: true


>>>>>>>>>>>>> Preparing the environment for Debugger Extensions Gallery repositories completed, duration 0.000 seconds

************* Waiting for Debugger Extensions Gallery to Initialize **************

>>>>>>>>>>>>> Waiting for Debugger Extensions Gallery to Initialize completed, duration 0.031 seconds
   ----> Repository : UserExtensions, Enabled: true, Packages count: 0
   ----> Repository : LocalInstalled, Enabled: true, Packages count: 29
---
test result: FAILED. 156 passed; 3 failed; 3 ignored; 0 measured; 0 filtered out; finished in 19.39s

Some tests failed in compiletest suite=debuginfo mode=debuginfo host=x86_64-pc-windows-msvc target=x86_64-pc-windows-msvc
Build completed unsuccessfully in 0:46:33
make: *** [Makefile:106: ci-msvc-ps1] Error 1
  network time: Sat, 16 Nov 2024 14:31:21 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2024-11-16T14:32:14Z

💔 Test failed - checks-actions

ehuss · 2024-11-16T14:35:54Z

@bors retry

msvc debuginfo issue

bors · 2024-11-17T06:39:50Z

⌛ Testing commit f6e913b with merge ee4a56e...

bors · 2024-11-17T09:44:42Z

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing ee4a56e to master...

rust-timer · 2024-11-17T11:02:47Z

Finished benchmarking commit (ee4a56e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.3%, 6.6%]	10
Regressions ❌ (secondary)	1.7%	[0.3%, 3.7%]	23
Improvements ✅ (primary)	-6.3%	[-25.1%, -0.1%]	73
Improvements ✅ (secondary)	-9.9%	[-67.2%, -0.3%]	22
All ❌✅ (primary)	-5.4%	[-25.1%, 6.6%]	83

Max RSS (memory usage)

Results (primary -7.9%, secondary -4.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[1.5%, 3.6%]	2
Regressions ❌ (secondary)	4.0%	[3.0%, 5.0%]	3
Improvements ✅ (primary)	-8.2%	[-22.1%, -1.6%]	67
Improvements ✅ (secondary)	-5.6%	[-15.8%, -1.5%]	31
All ❌✅ (primary)	-7.9%	[-22.1%, 3.6%]	69

Cycles

Results (primary -11.7%, secondary -18.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	3.2%	[2.5%, 4.6%]	3
Improvements ✅ (primary)	-11.9%	[-32.7%, -1.3%]	57
Improvements ✅ (secondary)	-25.2%	[-66.7%, -2.8%]	10
All ❌✅ (primary)	-11.7%	[-32.7%, 2.6%]	58

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 788.926s -> 789.102s (0.02%)
Artifact size: 335.45 MiB -> 335.46 MiB (0.00%)

…lly, r=<try> Querify should_codegen_locally I think this has a very strong interaction with rust-lang#132566, and may not be justifiable without that PR, so marking this as blocked until that is merged.

pnkfelix · 2024-11-19T22:46:27Z

Visiting for weekly perf triage

massive improvements; many incremental benchmarks are improved by 5% to 20% (and even 25% in the case of ripgrep)
the regressions here (mostly to helloworld) were anticipated during review and are far outweighed by the very notable gains in compiler performance across a broad swath of benchmarks.
marking as triaged

@rustbot label: +perf-regression-triaged

…lly, r=<try> Querify should_codegen_locally I think this has a very strong interaction with rust-lang#132566, and may not be justifiable without that PR, so marking this as blocked until that is merged.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2024