maintain the given order on step execution

[onur-ozkan]

Previously step execution disregarded the CLI order and this change executes the given steps in the order specified on CLI.

For example, running x $kind a b c will execute $kind step for a, then b, then c crates in the specified order.

Fixes #126165
cc @matthiaskrgr

[rustbot]

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[onur-ozkan]

I will re-work on this later again.

@rustbot author

[onur-ozkan]

Simplified the solution without refactoring the entire internals about path resolution (which was the case initially).

@rustbot ready

[Kobzol]

I'm a bit confused by the original issue. It used x test A B as an example, but most tests should be handled by this, and thus they should already be handled in the original order. Is there an example of a different command where order is important, but which is not handled by the suite logic?

[onur-ozkan]

It used x test A B as an example, but most tests should be handled by this, and thus they should already be handled in the original order.

That's not quite right. The logic below handles the step executions most of the time. The one you linked is supposed to handle specific test paths (like tests/something/test.rs).

To debug the ordering, you can run this command:

x test clippy miri bootstrap rustdoc sysroot --dry-run | grep Testing

and compare the CLI order to the executed steps.

[Kobzol]

Ah, I see, thanks. I guess that I usually run specific test paths, so I didn't think of this. I'll test it locally.

[Kobzol]

This is the first time I actually saw dry run being useful :) However it was in the mode where it was enabled manually (--dry-run), I'd still get rid of the double execution of all steps 😆

[onur-ozkan]

@bors r=Kobzol

[bors]

📌 Commit 4ad753a has been approved by Kobzol

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4ad753a with merge 3de0a7c...

[bors]

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 3de0a7c to master...

[rust-timer]

Finished benchmarking commit (3de0a7c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.259s -> 768.642s (0.05%)
Artifact size: 328.63 MiB -> 328.71 MiB (0.02%)