Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: div.where instead of fmt-newline class #118483

Merged
merged 1 commit into from
Dec 1, 2023
Merged

rustdoc: div.where instead of fmt-newline class #118483

merged 1 commit into from
Dec 1, 2023

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Nov 30, 2023 •
edited
Loading

This is about equally readable, a lot more terse, and stops special-casing functions and methods.

$ du -hs doc-old/ doc-new/
671M    doc-old/
670M    doc-new/

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 30, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2023

Some changes occurred in GUI tests.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@notriddle notriddle force-pushed the notriddle/fmt-newline branch from 6ad7894 to 4deff1c Compare November 30, 2023 17:35
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@notriddle
rustdoc: div.where instead of fmt-newline class
7230f6c 
This is about equally readable, a lot more terse, and stops
special-casing functions and methods.

```console
$ du -hs doc-old/ doc-new/
671M    doc-old/
670M    doc-new/
```
@notriddle notriddle force-pushed the notriddle/fmt-newline branch from 4deff1c to 7230f6c Compare November 30, 2023 17:43
@notriddle
Copy link
Contributor Author

@bors try
@rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 30, 2023
@bors
Copy link
Contributor

bors commented Nov 30, 2023

⌛ Trying commit 7230f6c with merge 895ba65...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2023
@bors
Auto merge of rust-lang#118483 - notriddle:notriddle/fmt-newline, r=<…
895ba65 
…try>

rustdoc: `div.where` instead of fmt-newline class

This is about equally readable, a lot more terse, and stops special-casing functions and methods.

```console
$ du -hs doc-old/ doc-new/
671M    doc-old/
670M    doc-new/
```
@GuillaumeGomez
Copy link
Member

Good idea! r=me once we have the perf results.

@bors
Copy link
Contributor

bors commented Nov 30, 2023

☀️ Try build successful - checks-actions
Build commit: 895ba65 (895ba65a41150039aa401dd52767ed34e8a7094f)

1 similar comment
@bors
Copy link
Contributor

bors commented Nov 30, 2023

☀️ Try build successful - checks-actions
Build commit: 895ba65 (895ba65a41150039aa401dd52767ed34e8a7094f)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (895ba65): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.0% [-2.0%, -2.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.048s -> 673.663s (0.24%)
Artifact size: 313.42 MiB -> 313.36 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 1, 2023
@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Dec 1, 2023

📌 Commit 7230f6c has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2023
@TaKO8Ki TaKO8Ki mentioned this pull request Dec 1, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2023
@bors
Auto merge of rust-lang#118493 - TaKO8Ki:rollup-jfkdbyo, r=TaKO8Ki
9bf30eb 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#118483 (rustdoc: `div.where` instead of fmt-newline class)
 - rust-lang#118486 (generic_const_exprs: suggest to add the feature, not use it)
 - rust-lang#118489 (Wesley is on vacation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a030add into rust-lang:master Dec 1, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 1, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2023
@rust-timer
Unrolled build for rust-lang#118483
4e4fe74 
Rollup merge of rust-lang#118483 - notriddle:notriddle/fmt-newline, r=GuillaumeGomez

rustdoc: `div.where` instead of fmt-newline class

This is about equally readable, a lot more terse, and stops special-casing functions and methods.

```console
$ du -hs doc-old/ doc-new/
671M    doc-old/
670M    doc-new/
```
@notriddle notriddle deleted the notriddle/fmt-newline branch December 1, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
6 participants
@notriddle @rustbot @rust-log-analyzer @rust-timer @bors @GuillaumeGomez