-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Clippy
] Use symbols intended for arithmetic_side_effects
#115415
Conversation
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
@rustbot labels -T-libs +T-compiler r? compiler Is there a better team? |
This comment has been minimized.
This comment has been minimized.
For some reason the original |
Next Clippy update is in 1 week. So this PR could only add the diag items and then the logic could be changed in a Clippy PR. But that would take another 2 weeks to get in. I'm good with making an exception here and making functional Clippy changes in the Rust repo in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The impl LGTM, but is there a Clippy issue associated with this, that could be linked in this PR?
r? @flip1995 |
Hehehe, sorry for the mess @flip1995. The related Clippy issue has been attached. |
This comment has been minimized.
This comment has been minimized.
That seemed to have worked. I rebased and squashed the blessing commits. Thanks! @bors r+ |
@bors rollup |
Nice! Thank you very much @flip1995 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d6b4d35): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.878s -> 629.909s (-0.31%) |
#115177 added the symbols for
arithmetic_side_effects
and now this PR actually uses them to prevent an eventual removal. All because #115183 was recently merged and next Clippy update will probably take some time to happen.Fixes rust-lang/rust-clippy#11392