Improve documentation for E0223 #109565
Merged
Improve documentation for E0223 #109565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
oli-obk
requested changes
Mar 24, 2023
| } | ||
| ``` | ||
|
|
||
| The problem here is that we're attempting to take the type of X from MyTrait. | ||
| Unfortunately, the type of X is not defined, because it's only made concrete in | ||
| The problem here is that we're attempting to take the type of `X` from `Trait`. |
There was a problem hiding this comment.
Suggested change
| The problem here is that we're attempting to take the type of `X` from `Trait`. | |
| The problem here is that we're attempting to take the associated type of `X` from `Trait`. |
Comment on lines
30
to
31
| This syntax specifies that we want the `X` type from `Trait` implementation for | ||
| `Struct`. |
There was a problem hiding this comment.
Suggested change
| This syntax specifies that we want the `X` type from `Trait` implementation for | |
| `Struct`. | |
| This syntax specifies that we want the associated type `X` from `Struct`'s | |
| implementation of `Trait`. |
rust-cloud-vms
bot
force-pushed
the
better_docs_for_e0223
branch
from
29b9145 to
3c4fabc
Compare
|
@bors r=oli-obk rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#108548 (Clarify the 'use a constant in a pattern' error message) - rust-lang#109565 (Improve documentation for E0223) - rust-lang#109661 (Fix LVI test post LLVM 16 update) - rust-lang#109667 (Always set `RUSTC_BOOTSTRAP` with `x doc`) - rust-lang#109669 (Update books) - rust-lang#109678 (Don't shadow the `dep_node` var in `incremental_verify_ich_failed`) - rust-lang#109682 (Add `#[inline]` to CStr trait implementations) - rust-lang#109685 (Make doc comment a little bit more accurate) - rust-lang#109687 (Document the heuristics IsTerminal uses on Windows) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Inconsistency.20in.20prohibiting.20.60Type.3A.3AAssocType.60