Implement non-const Destruct trait in new solver
#109495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
eholk
reviewed
Mar 22, 2023
eholk
reviewed
Mar 22, 2023
compiler-errors
force-pushed
the
new-solver-destruct
branch
from
0696591 to
a34c927
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
rustbot
added
the
S-waiting-on-review
bors
added
S-waiting-on-author
compiler-errors
added
S-waiting-on-review
|
@bors r=eholk,lcnr rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 24, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#109406 (Remove outdated comments) - rust-lang#109433 (Return equal for two identical projections) - rust-lang#109495 (Implement non-const `Destruct` trait in new solver) - rust-lang#109519 (Link against libc++ on AIX) - rust-lang#109550 (Make helper functions private in fn_ctxt/adjust_fulfillment_errors) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that we can call stdlib methods like
Option::mapin non-const environments, since many stdlib methods haveDestructbounds 😅This doesn't bother to implement
const Destructyet, but it shouldn't be too hard to do so. Just didn't bother since we already don't have much support for const traits in the new solver anyways. I'd be happy to add skeleton support forconst Destruct, though, if the reviewer desires.