Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: remove redundant CSS #crate-search { border-radius } #103162

Merged
merged 1 commit into from
Oct 18, 2022
Merged

rustdoc: remove redundant CSS #crate-search { border-radius } #103162

merged 1 commit into from
Oct 18, 2022

Conversation

notriddle
Copy link
Contributor

This is the same border-radius that's always set on that ID:

rust/src/librustdoc/html/static/css/rustdoc.css

Lines 825 to 836 in a9d1caf

#crate-search {
min-width: 115px;
padding: 0;
/* keep these two in sync with "@-moz-document url-prefix()" below */
padding-left: 4px;
padding-right: 23px;
/* prevents the <select> from overflowing the containing div in case it's shrunk */
max-width: 100%;
/* contents can overflow because of max-width limit, then show ellipsis */
text-overflow: ellipsis;
border: 1px solid var(--border-color);
border-radius: 4px;

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 17, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2022
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 17, 2022

📌 Commit 642bb0d has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2022
@bors
Auto merge of rust-lang#103165 - matthiaskrgr:rollup-guw8oh6, r=matth…
194140b 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#103152 (Use named arguments to make GUI test more clear)
 - rust-lang#103160 (rustdoc: factor JS mobile scroll lock into its own function)
 - rust-lang#103161 (rustdoc: remove redundant CSS on `#copy-path`)
 - rust-lang#103162 (rustdoc: remove redundant CSS `#crate-search { border-radius }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8a467c3 into rust-lang:master Oct 18, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 18, 2022
@notriddle notriddle deleted the notriddle/crate-search branch October 18, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@jsha jsha

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@notriddle @rustbot @rust-highfive @GuillaumeGomez @bors @jsha