-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler bug for a simple test file #6128
Comments
It seems you are using an old version of rust (based on your use of LinearMap, which has since been renamed to HashMap). Does this crash also happen on incoming? |
Looks like my computer is not powerful enough to build rust from git+/~https://github.com/mozilla/rust.git ... |
I tested with master (bfccfdc) And I get the same problem https://gist.github.com/Tristramg/5494814 |
Simpler test case:
Reproduced with 8d0feb5 . Nominating for milestone 5, production-ready. |
accepted for production-ready milestone |
I don't get ICE anymore. |
Hurrah! flagging as needstest, but this probably just needs the test case un-xfail'd |
The test was actually already checked in and was un-xfail'd in 364beaa |
Downgrade rc_buffer to restriction I think Arc\<Vec\<T\>\> and Arc\<String\> and similar are a totally reasonable data structure, as observed by others in the comments on [rust-lang#6044](rust-lang/rust-clippy#6044 (comment)) as well. Doing `Arc::make_mut(&mut self.vec).push(...)` or `Arc::make_mut(&mut self.string).push_str("...")` is a terrific and well performing copy-on-write pattern. Linting this with an enabled-by-default <kbd>performance</kbd> lint strikes me as an unacceptable false positive balance. As of rust-lang#6090 the documentation of this lint now contains: > **Known problems:** This pattern can be desirable ... which should indicate that we shouldn't be linting against correct, reasonable, well-performing patterns with an enabled-by-default lint. Mentioning rust-lang#6044, rust-lang#6090. r? `@yaahc,` who reviewed the lint. --- changelog: Remove rc_buffer from default set of enabled lints
…chenkov Move some tests to more reasonable directories - 3 cc rust-lang#73494 r? `@petrochenkov` /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-56202.rs <sup>/~https://github.com/rust-lang/rust/issues/56202</sup>: traits 1.008 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-69841.rs <sup>/~https://github.com/rust-lang/rust/issues/69841</sup>: for-loop-while 1.014 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-10763.rs <sup>/~https://github.com/rust-lang/rust/issues/10763</sup>: extern 1.016 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-50599.rs <sup>/~https://github.com/rust-lang/rust/issues/50599</sup>: resolve 1.018 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-6128.rs <sup>/~https://github.com/rust-lang/rust/issues/6128</sup>: traits 1.043 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-20616-8.rs <sup>/~https://github.com/rust-lang/rust/issues/20616</sup>: parser 1.045 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-46553.rs <sup>/~https://github.com/rust-lang/rust/issues/46553</sup>: consts 1.081 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-33140-hack-boundaries.rs <sup>/~https://github.com/rust-lang/rust/issues/33140</sup>: traits 1.101 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-25826.rs <sup>/~https://github.com/rust-lang/rust/issues/25826</sup>: consts 1.108 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-56488.rs <sup>/~https://github.com/rust-lang/rust/issues/56488</sup>: traits 1.110 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-58856-1.rs <sup>/~https://github.com/rust-lang/rust/issues/58856</sup>: parser 1.133 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-57819.rs <sup>/~https://github.com/rust-lang/rust/issues/57819</sup>: parser 1.138 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-54348.rs <sup>/~https://github.com/rust-lang/rust/issues/54348</sup>: consts 1.155 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-14309.rs <sup>/~https://github.com/rust-lang/rust/issues/14309</sup>: lint 1.160 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-4446.rs <sup>/~https://github.com/rust-lang/rust/issues/4446</sup>: threads-sendsync 1.203 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-53675-a-test-called-panic.rs <sup>/~https://github.com/rust-lang/rust/issues/53675</sup>: test-attrs 1.211 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-40231-2.rs <sup>/~https://github.com/rust-lang/rust/issues/40231</sup>: consts 1.213 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-22037.rs <sup>/~https://github.com/rust-lang/rust/issues/22037</sup>: associated-types 1.214 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-59029-2.rs <sup>/~https://github.com/rust-lang/rust/issues/59029</sup>: traits 1.219 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-18425.rs <sup>/~https://github.com/rust-lang/rust/issues/18425</sup>: consts 1.237 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-6157.rs <sup>/~https://github.com/rust-lang/rust/issues/6157</sup>: regions 1.238 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-33819.rs <sup>/~https://github.com/rust-lang/rust/issues/33819</sup>: borrowck 1.280 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-3683.rs <sup>/~https://github.com/rust-lang/rust/issues/3683</sup>: traits 1.283 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-8709.rs <sup>/~https://github.com/rust-lang/rust/issues/8709</sup>: macros 1.291 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-20616-9.rs <sup>/~https://github.com/rust-lang/rust/issues/20616</sup>: parser 1.293 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-64732.rs <sup>/~https://github.com/rust-lang/rust/issues/64732</sup>: parser 1.296 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-18655.rs <sup>/~https://github.com/rust-lang/rust/issues/18655</sup>: associated-types 1.305 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-32947.rs <sup>/~https://github.com/rust-lang/rust/issues/32947</sup>: simd 1.322 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-57198.rs <sup>/~https://github.com/rust-lang/rust/issues/57198</sup>: parser 1.342 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-10764-rpass.rs <sup>/~https://github.com/rust-lang/rust/issues/10764</sup>: extern 1.392 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-73541-2.rs <sup>/~https://github.com/rust-lang/rust/issues/73541</sup>: async-await 1.422 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-7970b.rs <sup>/~https://github.com/rust-lang/rust/issues/7970</sup>: parser 1.439 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-57684.rs <sup>/~https://github.com/rust-lang/rust/issues/57684</sup>: parser 1.512 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-33264.rs <sup>/~https://github.com/rust-lang/rust/issues/33264</sup>: llvm-asm 1.523 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-65284-suggest-generic-trait-bound.rs <sup>/~https://github.com/rust-lang/rust/issues/65284</sup>: suggestions 1.647 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-17458.rs <sup>/~https://github.com/rust-lang/rust/issues/17458</sup>: consts 1.711 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-56762.rs <sup>/~https://github.com/rust-lang/rust/issues/56762</sup>: consts 1.787 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-2216.rs <sup>/~https://github.com/rust-lang/rust/issues/2216</sup>: for-loop-while 1.856 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-45696-scribble-on-boxed-borrow.rs <sup>/~https://github.com/rust-lang/rust/issues/45696</sup>: nll 2.009 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-46036.rs <sup>/~https://github.com/rust-lang/rust/issues/46036</sup>: nll 2.059 `@petrochenkov` Can you put a place holder (like `N/A`) for tests without GitHub issues? It is a lot easier to parse fixed sized rows.
…chenkov Move some tests to more reasonable directories - 3 cc rust-lang#73494 r? ``@petrochenkov`` /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-56202.rs <sup>/~https://github.com/rust-lang/rust/issues/56202</sup>: traits 1.008 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-69841.rs <sup>/~https://github.com/rust-lang/rust/issues/69841</sup>: for-loop-while 1.014 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-10763.rs <sup>/~https://github.com/rust-lang/rust/issues/10763</sup>: extern 1.016 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-50599.rs <sup>/~https://github.com/rust-lang/rust/issues/50599</sup>: resolve 1.018 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-6128.rs <sup>/~https://github.com/rust-lang/rust/issues/6128</sup>: traits 1.043 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-20616-8.rs <sup>/~https://github.com/rust-lang/rust/issues/20616</sup>: parser 1.045 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-46553.rs <sup>/~https://github.com/rust-lang/rust/issues/46553</sup>: consts 1.081 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-33140-hack-boundaries.rs <sup>/~https://github.com/rust-lang/rust/issues/33140</sup>: traits 1.101 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-25826.rs <sup>/~https://github.com/rust-lang/rust/issues/25826</sup>: consts 1.108 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-56488.rs <sup>/~https://github.com/rust-lang/rust/issues/56488</sup>: traits 1.110 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-58856-1.rs <sup>/~https://github.com/rust-lang/rust/issues/58856</sup>: parser 1.133 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-57819.rs <sup>/~https://github.com/rust-lang/rust/issues/57819</sup>: parser 1.138 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-54348.rs <sup>/~https://github.com/rust-lang/rust/issues/54348</sup>: consts 1.155 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-14309.rs <sup>/~https://github.com/rust-lang/rust/issues/14309</sup>: lint 1.160 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-4446.rs <sup>/~https://github.com/rust-lang/rust/issues/4446</sup>: threads-sendsync 1.203 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-53675-a-test-called-panic.rs <sup>/~https://github.com/rust-lang/rust/issues/53675</sup>: test-attrs 1.211 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-40231-2.rs <sup>/~https://github.com/rust-lang/rust/issues/40231</sup>: consts 1.213 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-22037.rs <sup>/~https://github.com/rust-lang/rust/issues/22037</sup>: associated-types 1.214 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-59029-2.rs <sup>/~https://github.com/rust-lang/rust/issues/59029</sup>: traits 1.219 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-18425.rs <sup>/~https://github.com/rust-lang/rust/issues/18425</sup>: consts 1.237 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-6157.rs <sup>/~https://github.com/rust-lang/rust/issues/6157</sup>: regions 1.238 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-33819.rs <sup>/~https://github.com/rust-lang/rust/issues/33819</sup>: borrowck 1.280 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-3683.rs <sup>/~https://github.com/rust-lang/rust/issues/3683</sup>: traits 1.283 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-8709.rs <sup>/~https://github.com/rust-lang/rust/issues/8709</sup>: macros 1.291 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-20616-9.rs <sup>/~https://github.com/rust-lang/rust/issues/20616</sup>: parser 1.293 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-64732.rs <sup>/~https://github.com/rust-lang/rust/issues/64732</sup>: parser 1.296 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-18655.rs <sup>/~https://github.com/rust-lang/rust/issues/18655</sup>: associated-types 1.305 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-32947.rs <sup>/~https://github.com/rust-lang/rust/issues/32947</sup>: simd 1.322 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-57198.rs <sup>/~https://github.com/rust-lang/rust/issues/57198</sup>: parser 1.342 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-10764-rpass.rs <sup>/~https://github.com/rust-lang/rust/issues/10764</sup>: extern 1.392 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-73541-2.rs <sup>/~https://github.com/rust-lang/rust/issues/73541</sup>: async-await 1.422 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-7970b.rs <sup>/~https://github.com/rust-lang/rust/issues/7970</sup>: parser 1.439 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-57684.rs <sup>/~https://github.com/rust-lang/rust/issues/57684</sup>: parser 1.512 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-33264.rs <sup>/~https://github.com/rust-lang/rust/issues/33264</sup>: llvm-asm 1.523 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-65284-suggest-generic-trait-bound.rs <sup>/~https://github.com/rust-lang/rust/issues/65284</sup>: suggestions 1.647 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-17458.rs <sup>/~https://github.com/rust-lang/rust/issues/17458</sup>: consts 1.711 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-56762.rs <sup>/~https://github.com/rust-lang/rust/issues/56762</sup>: consts 1.787 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-2216.rs <sup>/~https://github.com/rust-lang/rust/issues/2216</sup>: for-loop-while 1.856 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-45696-scribble-on-boxed-borrow.rs <sup>/~https://github.com/rust-lang/rust/issues/45696</sup>: nll 2.009 /~https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-46036.rs <sup>/~https://github.com/rust-lang/rust/issues/46036</sup>: nll 2.059 ``@petrochenkov`` Can you put a place holder (like `N/A`) for tests without GitHub issues? It is a lot easier to parse fixed sized rows.
I got this stacktrace while running "rust test" on a file. The end of the trace contains a failure message. I have an archlinux 64bits, with rust-0.6-3 (compiled on april 6th, 2013). The code is at the bottom of the page.
code:
The text was updated successfully, but these errors were encountered: