Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtest: provide a way to run *all* tests #50363

Closed
vext01 opened this issue May 1, 2018 · 3 comments
Closed

libtest: provide a way to run *all* tests #50363

vext01 opened this issue May 1, 2018 · 3 comments
Labels
A-libtest Area: `#[test]` / the `test` library C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@vext01
Copy link
Contributor

vext01 commented May 1, 2018

I originally raised this against Cargo, but I've since learned that this is to do with libtest inside Rust itself.

So we have:

cargo test

To run all but ignored tests. Then:

cargo test -- --ignored

To run only ignored tests.

But as far as I can see there is no way to run all tests in parallel short of:

cargo test & cargo test -- --ignored

Which isn't ideal for scripting and is not convenient.

How about?

cargo test -- --all

Cheers
@pietroalbini pietroalbini added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-libtest Area: `#[test]` / the `test` library labels May 1, 2018
@Emerentius Emerentius mentioned this issue Aug 19, 2018
Merged
@Emerentius
Copy link
Contributor

Exercism depends a lot on ignored-by-default tests so this would be really useful. A short look over libtest makes me believe that this would be very easy to add. I'll try my hand at it.

@Emerentius Emerentius mentioned this issue Aug 20, 2018
Merged
bors added a commit that referenced this issue Sep 15, 2018
@bors
Auto merge of #53527 - Emerentius:test_all, r=nrc
9f53c87 
Add option to run all tests

This adds the "--include-ignored" flag to libtest, which allows running ignored and unignored tests in one go.

Closes #50363
@eddyb
Copy link
Member

eddyb commented Sep 15, 2018

Reopening because I had to revert #53527 to land edition-critical #54116.

@eddyb eddyb reopened this Sep 15, 2018
@Emerentius Emerentius mentioned this issue Oct 13, 2018
Merged
bors added a commit that referenced this issue Oct 27, 2018
@bors
Auto merge of #55053 - Emerentius:test_all_again, r=alexcrichton
42c11de 
Add option to run all tests, again

This is a repeat of #53527, which had to be reverted to land #54116. It will break clippy until `compiletest-rs` can be updated and I believe we're closing on a new release date, so this may need to be delayed again until after 1.30 is out (?)

Closes #50363 again
@corneliusroemer
Copy link

@Emerentius I came here because I'm just working through Excercism and don't want to uncomment all the ignored tests ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-libtest Area: `#[test]` / the `test` library C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@eddyb @vext01 @pietroalbini @Emerentius @corneliusroemer