Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0318 needs to be updated to new format #35322

Closed
sophiajt opened this issue Aug 4, 2016 · 0 comments
Closed

E0318 needs to be updated to new format #35322

sophiajt opened this issue Aug 4, 2016 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

From: src/test/compile-fail/typeck-default-trait-impl-outside-crate.rs

Error E0318 needs a span label, a note, and an updated title, updating it from:

error[E0318]: cannot create default implementations for traits outside the crate they're defined in; define a new trait instead
  --> src/test/compile-fail/typeck-default-trait-impl-outside-crate.rs:13:1
   |
13 | impl Copy for .. {}
   | ^^^^^^^^^^^^^^^^^^^

To:

error[E0318]: cannot create default implementations for traits outside the crate they're defined in
  --> src/test/compile-fail/typeck-default-trait-impl-outside-crate.rs:13:1
   |
13 | impl Copy for .. {}
   | ^^^^^^^^^^^^^^^^^^^ `Copy` trait not defined in this crate
   |
   = note: define a new trait instead 

Bonus: narrow the span to focus on the foreign trait

error[E0318]: cannot create default implementations for traits outside the crate they're defined in
  --> src/test/compile-fail/typeck-default-trait-impl-outside-crate.rs:13:1
   |
13 | impl Copy for .. {}
   |      ^^^^ trait not defined in this crate
   |
   = note: define a new trait instead 
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 4, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 29, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 31, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

1 participant