Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of outdated logging functions in util::common #2553

Closed
lkuper opened this issue Jun 8, 2012 · 2 comments
Closed

get rid of outdated logging functions in util::common #2553

lkuper opened this issue Jun 8, 2012 · 2 comments

Comments

@lkuper
Copy link
Contributor

lkuper commented Jun 8, 2012

The log_* functions in util::common predate the logging macros and are used in only a handful of places in the compiler. Some aren't being used at all. We should get rid of them and replace the few places they're being used with #debug and #error.
@catamorphism
Copy link
Contributor

A debug_expr macro (for example) would be nice. It's a bit clunky to have to type out #debug("visiting %s", expr_to_str(e)); or whatever all the time. Then debug_expr could be governed by the same logging flags that affect whether #debug and #error macro calls print their results.

@lkuper
Copy link
Contributor Author

lkuper commented Jun 9, 2012

@catamorphism I'm not sure how widely used it would be, considering how little-used these were, but you could always open an issue for #debug_expr

@lkuper lkuper closed this as completed in 7c0fd85 Jun 9, 2012
oli-obk pushed a commit to oli-obk/rust that referenced this issue Sep 20, 2022
@bors
Auto merge of rust-lang#2553 - RalfJung:macos-is-a-pain, r=RalfJung
eb84c8b 
make a sync test more reliable

CI still failed in /~https://github.com/rust-lang/miri/actions/runs/3088146532/jobs/4994285794, with a 2 second timeout?!??
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval
Fix flaky tests (rust-lang#2553)
43bc890 
This PR fixes a few flaky tests that started to fail in the ongoing toolchain update (rust-lang#2551)

- The object bits test itself doesn't create that many objects since an array is represented as the same allocated object. Use LinkedList instead.
- Do not rely on property number.
- Do not rely on the order that failed checks is printed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catamorphism @lkuper