Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Src Link in Rustdoc fails for assert_eq! #21311

Closed
estsauver opened this issue Jan 17, 2015 · 5 comments
Closed

Src Link in Rustdoc fails for assert_eq! #21311

estsauver opened this issue Jan 17, 2015 · 5 comments
Assignees
@alexcrichton
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@estsauver
Copy link
Contributor

Step 1: Visit http://doc.rust-lang.org/std/macro.assert_eq!.html
Step 2: Click Link [src]

Page should link to http://doc.rust-lang.org/src/core/macros.rs.html#80-93, but instead links to http://doc.rust-lang.org/src/std/%3Ccore%20macros%3E.html#1-9

Suggested label A-Docs A-Rustdoc
@steveklabnik
Copy link
Member

Not sure this isn't a dup...

@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 17, 2015
@tomjakubowski
Copy link
Contributor

rustdoc has some special logic to redirect through re-exports for items, but similar logic wasn't added for "re-exported" macros after macro reform.

@steveklabnik steveklabnik mentioned this issue Feb 10, 2015
Closed
This was referenced Apr 10, 2015
Closed
Open
@alexcrichton alexcrichton self-assigned this Apr 10, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 14, 2015
@alexcrichton
rustdoc: Fix cross-crate macro source links
bf1ecd7 
The source filename for cross crate macros isn't quite right so the normal
generated links are invalid.

Closes rust-lang#21311
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 15, 2015
@alexcrichton
rustdoc: Fix cross-crate macro source links
47e0818 
The source filename for cross crate macros isn't quite right so the normal
generated links are invalid.

Closes rust-lang#21311
quantheory pushed a commit to quantheory/rust that referenced this issue Apr 17, 2015
@alexcrichton @quantheory
rustdoc: Fix cross-crate macro source links
a27aa8e 
The source filename for cross crate macros isn't quite right so the normal
generated links are invalid.

Closes rust-lang#21311
@Meyermagic
Copy link
Contributor

Just as a note, at time of writing this problem still exists in the beta docs. Might want to cherry pick the change to beta.

@steveklabnik
Copy link
Member

@alexcrichton what do you think, should we backport this?

@alexcrichton
Copy link
Member

I'd be fine doing so, although I thought that the main PR fixing rustdoc made it into a master -> beta merge... Ah well, either way is fine by me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @alexcrichton @Meyermagic @tomjakubowski @estsauver