Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest overwrites PYTHONPATH #108779

Closed
albertlarsan68 opened this issue Mar 5, 2023 · 0 comments · Fixed by #108793
Closed

compiletest overwrites PYTHONPATH #108779

albertlarsan68 opened this issue Mar 5, 2023 · 0 comments · Fixed by #108793
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@albertlarsan68
Copy link
Member

I tried running x t tests/debuginfo/basic-types-globals-metadata.rs, with the PYTHONPATH env variable set, as a workaround for rust-lang/simpleinfra#254.
However, it does not work, because compiletest or bootstrap overwrites the env variable instead of simply appending/prepending.
@albertlarsan68 albertlarsan68 added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Mar 5, 2023
@clubby789 clubby789 mentioned this issue Mar 6, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 7, 2023
@matthiaskrgr
Rollup merge of rust-lang#108793 - clubby789:pythonpath-compiletest, …
c4453cc 
…r=compiler-errors

Append to existing `PYTHONPATH` in compiletest instead of overwriting

Fixes rust-lang#108779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Append to existing PYTHONPATH in compiletest instead of overwriting clubby789/rust
1 participant
@albertlarsan68