Deploy time travel #5517
Merged
Deploy time travel #5517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors try |
bors
added a commit
that referenced
this pull request
Apr 23, 2020
Deploy time travel Since not only commits to the master branch, but also tags and the beta branch are deployed, we have to be cautious which version of the deploy script is used. GHA always runs the workflow that is commited on the `ref`, that gets tested. For tagged commits. this is 6 weeks outdated workflows/scripts. To prevent this, this workflow first checks out the deploy.sh script, the website templates and all python scripts generating files for the website. changelog: none
flip1995
force-pushed
the
deploy_time_travel
branch
from
6d12a66 to
2de8115
Compare
flip1995
added
the
S-waiting-on-review
flip1995
force-pushed
the
deploy_time_travel
branch
from
89481af to
7e579a6
Compare
flip1995
force-pushed
the
deploy_time_travel
branch
from
7e579a6 to
0476e8b
Compare
Manishearth
approved these changes
Apr 23, 2020
|
@bors r=Manishearth |
|
📌 Commit 0476e8b has been approved by |
bors
added a commit
that referenced
this pull request
Apr 23, 2020
Deploy time travel Since not only commits to the master branch, but also tags and the beta branch are deployed, we have to be cautious which version of the deploy script is used. GHA always runs the workflow that is commited on the `ref`, that gets tested. For tagged commits. this is 6 weeks outdated workflows/scripts. To prevent this, this workflow first checks out the deploy.sh script, the website templates and all python scripts generating files for the website. changelog: none
|
💔 Test failed - checks-action_test |
flip1995
added
S-waiting-on-bors
|
@bors retry |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 25, 2020
…hearth Deploy time travel Since not only commits to the master branch, but also tags and the beta branch are deployed, we have to be cautious which version of the deploy script is used. GHA always runs the workflow that is commited on the `ref`, that gets tested. For tagged commits. this is 6 weeks outdated workflows/scripts. To prevent this, this workflow first checks out the deploy.sh script, the website templates and all python scripts generating files for the website. changelog: none
This was referenced Apr 25, 2020
bors
added a commit
that referenced
this pull request
Apr 25, 2020
Rollup of 5 pull requests Successful merges: - #5408 (Downgrade match_bool to pedantic) - #5505 (Avoid running cargo+internal lints when not enabled) - #5516 (Add a note to the beta sections of release.md) - #5517 (Deploy time travel) - #5523 (Add lifetime test case for `new_ret_no_self`) Failed merges: r? @ghost changelog: rollup
4 tasks
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Jul 28, 2021
…ednet,flip1995 Switch CI to new metadata collection r? `@xFrednet` Things we have to keep in mind: - This removes the template files and the scripts used for deployment from the checkout. This was added in rust-lang#5517. I don't think we ever needed those there. Not sure though. - ~~As a result, we can't remove the python scripts yet. We have to wait until this hits a stable Clippy release.~~ I'll just break the next stable deploy and do it by hand once. - This should be merged together with rust-lang#7279. Me and `@xFrednet` will coordinate the switch - ...? I still have to try out some things: - [x] Is it worth caching? Yes - [x] ~~Is it worth to do a release build?~~ Nope - [x] Does it actually work? With a few changes, yes - [ ] ...? changelog: Clippy now uses a lint to generate its documentation 🎉
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Jul 28, 2021
…ednet,flip1995 Switch CI to new metadata collection r? `@xFrednet` Things we have to keep in mind: - This removes the template files and the scripts used for deployment from the checkout. This was added in rust-lang#5517. I don't think we ever needed those there. Not sure though. - ~~As a result, we can't remove the python scripts yet. We have to wait until this hits a stable Clippy release.~~ I'll just break the next stable deploy and do it by hand once. - This should be merged together with rust-lang#7279. Me and `@xFrednet` will coordinate the switch - ...? I still have to try out some things: - [x] Is it worth caching? Yes - [x] ~~Is it worth to do a release build?~~ Nope - [x] Does it actually work? With a few changes, yes - [ ] ...? changelog: Clippy now uses a lint to generate its documentation 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since not only commits to the master branch, but also tags and the beta branch are deployed, we have to be cautious which version of the deploy script is used. GHA always runs the workflow that is commited on the
ref, that gets tested. For tagged commits. this is 6 weeks outdated workflows/scripts. To prevent this, this workflow first checks out the deploy.sh script, the website templates and all python scripts generating files for the website.changelog: none