Fix deploy script for tag deploys #5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-waiting-on-review
flip1995
force-pushed
the
tag_deploy_fix
branch
from
d76c475 to
f822497
Compare
|
@bors r+ |
|
📌 Commit f822497 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 5, 2020
Fix deploy script for tag deploys By hand updating the documentation for the `rust-1.41.1` release, I found, that the deploy script was buggy for tag deploys. Luckily we weren't affected yet (will only run if the commit of the tag already has the workflow config, so probably ~`rust-1.43.0`) The bug: When a tag was deployed, until now it also updated the master documentation to the state of the tag. This was because the `git add .` not only updated the files created or modified by the tag commit, but also the master lints.json file. changelog: none
|
💔 Test failed - checks-action_test |
looks like another rustup might be needed? |
|
Not a Clippy issue: rust-lang-deprecated/failure#342 |
|
@bors retry (new versions were released) |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By hand updating the documentation for the
rust-1.41.1release, I found, that the deploy script was buggy for tag deploys. Luckily we weren't affected yet (will only run if the commit of the tag already has the workflow config, so probably ~rust-1.43.0)The bug:
When a tag was deployed, until now it also updated the master documentation to the state of the tag. This was because the
git add .not only updated the files created or modified by the tag commit, but also the master lints.json file.changelog: none