Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change while_let_loop applicability to HasPlaceholders #3975

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Apr 16, 2019

The suggestion has been changed at some point to use .. in the suggested code.
Due to that we can't make the lint MachineApplicable anymore.

cc #3630

Due to that we can't make the lint MachineApplicable anymore.
@phansch phansch changed the title while_let_loop uses placeholders in suggestions Change while_let_loop applicability to HasPlaceholders Apr 16, 2019
@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 16, 2019
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 16, 2019

📌 Commit e974d84 has been approved by flip1995

bors added a commit that referenced this pull request Apr 17, 2019
Change while_let_loop applicability to HasPlaceholders

The suggestion has been changed at some point to use `..` in the suggested code.
Due to that we can't make the lint MachineApplicable anymore.

cc #3630
@bors
Copy link
Contributor

bors commented Apr 17, 2019

⌛ Testing commit e974d84 with merge 1132caa...

@bors
Copy link
Contributor

bors commented Apr 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 1132caa to master...

@bors bors merged commit e974d84 into rust-lang:master Apr 17, 2019
@phansch phansch deleted the has_placeholders branch April 17, 2019 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants