Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are our many-seeds tests failing on Windows? #3405

Closed
RalfJung opened this issue Mar 24, 2024 · 0 comments · Fixed by #3406
Closed

Are our many-seeds tests failing on Windows? #3405

RalfJung opened this issue Mar 24, 2024 · 0 comments · Fixed by #3406

Comments

@RalfJung
Copy link
Member

I just noticed this in our Windows CI logs:

  + ./miri many-seeds ./miri run tests/many-seeds/scoped-thread-leak.rs
  Trying seed: 0
  Failing seed: 0

There seem to be multiple things wrong here:

  • Why is the test failing?
  • Why is there no error message?
  • Why does CI succeed anyway?
@RalfJung RalfJung mentioned this issue Mar 24, 2024
Merged
bors added a commit that referenced this issue Mar 24, 2024
@bors
Auto merge of #3406 - RalfJung:many-seeds, r=RalfJung
344ea00 
many-seeds: propagate failure properly

This may help explain #3405.
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 25, 2024
@bors
Auto merge of rust-lang#3406 - RalfJung:many-seeds, r=RalfJung
f97f448 
many-seeds: propagate failure properly

This may help explain rust-lang/miri#3405.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

many-seeds: propagate failure properly RalfJung/miri
1 participant
@RalfJung