-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add POSIX confstr API #3771
Add POSIX confstr API #3771
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Status: all tests except |
|
Status: Narrowed to strictly gnu-linux, as the updated OP describes more fully. Ready for merging, with an aspiration to see wider |
fair enough, even tough I believe musl for example has it too for example but that s fair as is :) |
The Platonic ideal would seem to be "confstr on all unix except x, y, and z" but that is difficult to express in the semver tests, I'm guessing. Further complicating the task is that value of |
[fix conflicts - Trevor] (backport <rust-lang#3771>) (cherry picked from commit 31beed6) Signed-off-by: Trevor Gross <tmgross@umich.edu>
Fixes #3767
Some notes for reviewers:
getconf
util implementation at /~https://github.com/rustcoreutils/posixutils-rsconfstr(3)
APIunix
, because it is POSIX standard, just likesysconf(3)
, and originates from libc, just likesysconf(3)
. This failed to due a single platform, arm-android.confstr
.This patch chooses the more limited path of focusing on linux-gnu, given that the symbols (not the function!) are glibc-specific.