Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for windows verbatim disk paths #112

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

nico-abram
Copy link
Contributor

Fixes #111

@nico-abram
Copy link
Contributor Author

nico-abram commented Apr 20, 2022

Replaced matches! with an if-let. CI runs on an old rustc so it was failing and I don't know what glob's MSRV policy is.

@swiftcoder
Copy link

Pulled this patch locally and confirmed it addresses the issue observed in getzola/zola#1932.

Happy to help out, should an extra pair of hands be needed to merge and release.

@JohnTitor
Copy link
Member

Seems you disabled access to this branch, could you rebase to trigger the latest CI?

@nico-abram
Copy link
Contributor Author

Rebased.

Edits by maintainers seems to be enabled:
imagen

@JohnTitor
Copy link
Member

Edits by maintainers seems to be enabled

Hmm, that's weird, maybe I force-pushed for rebasing and that's a culprit.

Anyway, this LGTM, thank you for the PR and sorry for the long delay!

@JohnTitor JohnTitor merged commit 55d550e into rust-lang:master Jan 11, 2023
@Wumpf
Copy link

Wumpf commented Feb 11, 2023

Just ran into the exact same issue fixed here after hunting down why a buildscript didn't behave properly on Windows.
Any chance this could get into a bug-fix release any time soon? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Std-Canonicalized windows paths don't work
4 participants