-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async GzDecoder #185
Async GzDecoder #185
Conversation
Thanks for the PR! I've done a quick skim over this and was wondering if a few high-level points could be knocked out before doing a deeper review:
|
|
Right yeah I don't think we need to deal with I'm not sure I understand your comments about |
I may have thought wrong before. :( |
ping? @alexcrichton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh oops sorry for the delay!
Ok looks good to me, thanks! |
Can you release a new version for it? |
Published! |
This PR implements async gzip header parsing. It will fixed #179 .
It changed some behavior ofGzDecoder
and was a breaking change.