-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to new tokio API #183
Conversation
This should be helpful to introduce new async features, and maybe it could ease the migration to the currently unstable futures.
Thanks for this! I'd be somewhat wary though about changing names of the feautres, but |
Ups, you are totally right! 😅 I will revert back the feature name and I will use the sub-crates of |
* Using `tokio-io` as dependency instead of the whole `tokio` crate * Reverted back to `tokio` for the feature name (because `tokio` crate is not imported anymore) * Using `tokio-tcp` and `tokio-threadpool` for the test
A small note: I arbitrarily decided to use It should be possible to use |
Thanks! I think now this PR is largely just updating some idioms, having stricter requirements on the tokio-io and futures crates, and updating tests, right? If so I think it's safe to skip the version bump here as I don't think it'll be critical to get out to crates.io |
I was not sure about the version bump, because of the old `tokio-core' and a few differences with the current environment. At the end I bumped just because if we forgot about it and merged, if could be a mess. Surely the |
I think that tokio-core is only used during this crate's own tests and not used externally though, so the changes for users on crates.io are just internal rewrites. Otherwise the crate both before and after should compile with the same set of compilers and crates. |
Perfect! If it is ok, I can change the version bump to 1.0.7, or I can revert it back to 1.0.6 if you would rather to include some other changes before the new version. |
Since this is now largely a cleanup PR I'd prefer to leave it at 1.0.6 and we can let these changes ride to crates.io on the next bump |
As discussed in rust-lang#183
Thanks! |
This should be helpful to introduce new async features, and maybe it
could ease the migration to the currently unstable futures.
I had to change the name of the feature from 'tokio' to 'async', because we cannot have crates and features with the same name.
Any feedback is appreciated!