Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zsh completion #10613

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Fix zsh completion #10613

merged 1 commit into from
Apr 29, 2022

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Fixes #10612

How should we test and review this PR?

# under cargo project directory
fpath+=$PWD/src/etc
compinit

# test it
cargo b<tab>

@bors r? @epage

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2022
@epage
Copy link
Contributor

epage commented Apr 29, 2022

@bors r+

Looking forward to clap_complete getting dynamic completion support (or a good option for testing shell completions). Making blind changes isn't optimal.

@bors
Copy link
Contributor

bors commented Apr 29, 2022

📌 Commit f7cca28 has been approved by epage

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2022
@bors
Copy link
Contributor

bors commented Apr 29, 2022

⌛ Testing commit f7cca28 with merge 78b10d4...

@bors
Copy link
Contributor

bors commented Apr 29, 2022

☀️ Test successful - checks-actions
Approved by: epage
Pushing 78b10d4 to master...

@bors bors merged commit 78b10d4 into rust-lang:master Apr 29, 2022
@weihanglo weihanglo deleted the issue-10612 branch April 30, 2022 01:53
@ehuss ehuss mentioned this pull request May 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2022
@bors
Auto merge of rust-lang#96693 - ehuss:update-cargo, r=ehuss
fed2c43 
Update cargo

7 commits in f63f23ff1f1a12ede8585bbd1bbf0c536e50293d..a44758ac805600edbb6ba51e7e6fb81a6077c0cd
2022-04-28 03:15:50 +0000 to 2022-05-04 02:29:34 +0000
- Add support for `-Zbuild-std` to `cargo fetch` (rust-lang/cargo#10129)
- Migrate tests of `cargo-init` to snapbox (rust-lang/cargo#10620)
- dedupe toml_edit crate, followup rust-lang/cargo#10603 (rust-lang/cargo#10619)
- Update GitHub Actions actions/checkout@v2 to v3 (rust-lang/cargo#10618)
- Integrate snapbox in with cargo-test-support (rust-lang/cargo#10581)
- Fix zsh completion (rust-lang/cargo#10613)
- Update documentation for workspace inheritance (rust-lang/cargo#10611)
@epage epage mentioned this pull request May 19, 2022
Open
14 tasks
@ehuss ehuss added this to the 1.62.0 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epage epage

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

nightly cargo zsh completion is broken
5 participants
@weihanglo @epage @bors @ehuss @rust-highfive