Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: update htslib and corresponding bindings to 1.16 #366

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

johanneskoester
Copy link
Contributor

No description provided.

@johanneskoester johanneskoester changed the title perf: update htslib and corresponding bindings perf: update htslib and corresponding bindings to 1.16 Oct 12, 2022
@johanneskoester
Copy link
Contributor Author

@pmarks could you help me here? I must admit that I have no idea anymore about the build process of hts-sys. As far as I remember, you redesigned it some time ago. In case something in the rust code needs to be adapted to API changes, let me know. But currently, the errors rather look like I am doing something wrong with the update of htslib and the bindings itself.

@johanneskoester
Copy link
Contributor Author

Also, while I tried to manually generate the prebuilt bindings for linux, I cannot do that for osx, since I don't have an apple machine here.

@coveralls
Copy link

coveralls commented Oct 12, 2022

Pull Request Test Coverage Report for Build 3238557950

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.776%

Totals Coverage Status
Change from base Build 3233164183: 0.0%
Covered Lines: 2253
Relevant Lines: 2860

💛 - Coveralls

@pmarks
Copy link
Contributor

pmarks commented Oct 13, 2022

@johanneskoester I think this is good to go.

@johanneskoester
Copy link
Contributor Author

Awesome, thanks a lot!

@johanneskoester johanneskoester merged commit f597ce0 into master Oct 13, 2022
@johanneskoester johanneskoester deleted the perf/htslib-1.16 branch October 13, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants