Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dep on umaintained difflib #515

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Remove dep on umaintained difflib #515

merged 1 commit into from
Jan 21, 2019

Conversation

SamWhited
Copy link

@SamWhited SamWhited commented Jan 1, 2019

This removes the testing dependency on github.com/pmezard/go-difflib which, per the README, is no longer maintained.

I did not try to match the diff output exactly, assuming these weren't actual patches being applied somewhere, but the relevant information is still included.

A failing test now looks like this:

blackfriday (v2 *=) $ go test
--- FAIL: TestReference_EXTENSION_NO_EMPTY_LINE_BEFORE_BLOCK (8.09s)
    helpers_test.go:173:
        file: Amps and angle encoding

        line: 6

        -<p>4 &lt; 6.</p>
        +<p>4 &lt; 5.</p>

        line: 16

        -<p>Here's an inline <a href="/script?foo=1&amp;bar=2">link</a></p>
        +<p>Here's an inline <a href="/script?foo=1&amp;bar=2">link</a>.</p>
--- FAIL: TestReference (7.16s)
    helpers_test.go:173:
        file: Amps and angle encoding

        line: 6

        -<p>4 &lt; 6.</p>
        +<p>4 &lt; 5.</p>

        line: 16

        -<p>Here's an inline <a href="/script?foo=1&amp;bar=2">link</a></p>
        +<p>Here's an inline <a href="/script?foo=1&amp;bar=2">link</a>.</p>
FAIL
exit status 1
FAIL    github.com/russross/blackfriday/v2      8.318s

@SamWhited
Copy link
Author

Rebased on top of #509

@rtfb
Copy link
Collaborator

rtfb commented Jan 21, 2019

Thanks, Sam! It's great that we got away with so few lines of extra code instead of this dependency.

@rtfb rtfb merged commit 792d134 into russross:v2 Jan 21, 2019
@SamWhited SamWhited deleted the remove_unmaintained_dep branch January 21, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants