fix: sort volume args in DOCKER_COMPAT mode #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningziwen
force-pushed
the
sort
branch
4 times, most recently
from
5b4e214 to
66f0e6d
Compare
ningziwen
commented
May 26, 2023
ningziwen
force-pushed
the
sort
branch
2 times, most recently
from
68a181a to
6ecf692
Compare
pendo324
approved these changes
May 26, 2023
pendo324
requested changes
May 26, 2023
austinvazquez
previously approved these changes
May 26, 2023
monirul
suggested changes
May 26, 2023
ningziwen
force-pushed
the
sort
branch
2 times, most recently
from
8023723 to
59b6fb3
Compare
monirul
previously approved these changes
May 26, 2023
pendo324
previously approved these changes
May 26, 2023
Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
pendo324
approved these changes
May 26, 2023
pendo324
approved these changes
May 26, 2023
pendo324
approved these changes
May 26, 2023
pendo324
approved these changes
May 26, 2023
vsiravar
pushed a commit
that referenced
this pull request
Jun 2, 2023
🤖 I have created a release *beep* *boop* --- ## [0.6.2](v0.6.1...v0.6.2) (2023-06-02) ### Bug Fixes * sort volume args in DOCKER_COMPAT mode ([#417](#417)) ([6a8ca1a](6a8ca1a)) * Stop lima process in postinstall and uninstall ([#438](#438)) ([975c4ee](975c4ee)) ### Build System or External Dependencies * **deps:** Bump github.com/docker/docker from 23.0.6+incompatible to 24.0.0+incompatible ([#406](#406)) ([25aa324](25aa324)) * **deps:** Bump github.com/docker/docker from 24.0.0+incompatible to 24.0.1+incompatible ([#413](#413)) ([bb1cab2](bb1cab2)) * **deps:** Bump github.com/docker/docker from 24.0.1+incompatible to 24.0.2+incompatible ([#419](#419)) ([f6f8aeb](f6f8aeb)) * **deps:** Bump github.com/lima-vm/lima from 0.15.1 to 0.16.0 ([#428](#428)) ([6a67f0c](6a67f0c)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.9.5 to 2.9.7 ([#432](#432)) ([0a381f1](0a381f1)) * **deps:** Bump github.com/onsi/gomega from 1.27.6 to 1.27.7 ([#409](#409)) ([80513c7](80513c7)) * **deps:** Bump github.com/runfinch/common-tests from 0.6.5 to 0.7.0 ([#420](#420)) ([ac18046](ac18046)) * **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.4 to 3.23.5 ([#437](#437)) ([8635294](8635294)) * **deps:** Bump github.com/sirupsen/logrus from 1.9.0 to 1.9.1 ([#405](#405)) ([05b6b2e](05b6b2e)) * **deps:** Bump github.com/sirupsen/logrus from 1.9.1 to 1.9.2 ([#408](#408)) ([0ff477a](0ff477a)) * **deps:** Bump github.com/stretchr/testify from 1.8.2 to 1.8.4 ([#429](#429)) ([0f7750e](0f7750e)) * **deps:** Bump golang.org/x/tools from 0.9.1 to 0.9.3 ([#443](#443)) ([b192874](b192874)) * **deps:** Bump k8s.io/apimachinery from 0.27.1 to 0.27.2 ([#407](#407)) ([e6cbd2c](e6cbd2c)) * **deps:** Bump submodules ([#402](#402)) ([06d86b2](06d86b2)) * **deps:** Bump submodules ([#439](#439)) ([e9551b5](e9551b5)) --- This PR was generated with [Release Please](/~https://github.com/googleapis/release-please). See [documentation](/~https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#418
Description of changes:
Sort volume args in DOCKER_COMPAT mode
Testing done:
Unit tests and new e2e tests. runfinch/common-tests#66
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.